Merge branch 'knewbury01/Declarations6' of https://github.com/knewbury01/codeql-coding-standards into knewbury01/Declarations6

Author: knewbury01

.github/pull_request_template.md

@@ -32,6 +32,12 @@ _**Author:**_ Is a change note required?
   - [ ] Yes
   - [ ] No
 
+🚨🚨🚨
+_**Reviewer:**_ Confirm that format of *shared* queries (not the .qll file, the
+.ql file that imports it) is valid by running them within VS Code. 
+  - [ ] Confirmed
+
+
 _**Reviewer:**_ Confirm that either a change note is not required or the change note is required and has been added.
   - [ ] Confirmed
 

.vscode/tasks.json

@@ -206,6 +206,8 @@
                 "Declarations",
                 "Declarations1",
                 "Declarations2",
+                "Declarations3",
+                "Declarations4",
                 "Declarations6",
                 "Exceptions1",
                 "Exceptions2",

c/common/src/codingstandards/c/Identifiers.qll

@@ -0,0 +1,2 @@
+| test.c:1:5:1:6 | definition of g1 | The identifier g1 has external linkage and is redefined $@. | test1.c:1:5:1:6 | definition of g1 | here |
+| test.c:6:6:6:7 | definition of f2 | The identifier f2 has external linkage and is redefined $@. | test1.c:6:6:6:7 | definition of f2 | here |

c/common/test/rules/identifierwithexternallinkageonedefinitionshared/IdentifierWithExternalLinkageOneDefinitionShared.expected

@@ -0,0 +1,2 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.identifierwithexternallinkageonedefinitionshared.IdentifierWithExternalLinkageOneDefinitionShared

c/common/test/rules/identifierwithexternallinkageonedefinitionshared/IdentifierWithExternalLinkageOneDefinitionShared.ql

@@ -0,0 +1,6 @@
+int g1 = 1;        // NON_COMPLIANT
+static int g2 = 1; // COMPLIANT; internal linkage
+
+inline void f1() {} // COMPLIANT; inline functions are an exception
+
+void f2() {} // NON_COMPLIANT

c/common/test/rules/identifierwithexternallinkageonedefinitionshared/test.c

@@ -0,0 +1,6 @@
+int g1 = 0;        // NON_COMPLIANT
+static int g2 = 1; // COMPLIANT; internal linkage
+
+inline void f1() {} // COMPLIANT; inline functions are an exception
+
+void f2() {} // NON_COMPLIANT

c/common/test/rules/identifierwithexternallinkageonedefinitionshared/test1.c

@@ -14,7 +14,7 @@
 
 import cpp
 import codingstandards.c.misra
-import codingstandards.c.Identifiers
+import codingstandards.cpp.Identifiers
 
 from Macro m, InterestingIdentifiers i, string mName, string iName
 where

c/misra/src/rules/RULE-5-5/IdentifiersNotDistinctFromMacroNames.ql

@@ -14,7 +14,7 @@
 
 import cpp
 import codingstandards.c.misra
-import codingstandards.c.Identifiers
+import codingstandards.cpp.Identifiers
 
 from TypedefType t, InterestingIdentifiers d
 where

c/misra/src/rules/RULE-5-6/TypedefNameNotUnique.ql

@@ -14,7 +14,7 @@
 
 import cpp
 import codingstandards.c.misra
-import codingstandards.c.Identifiers
+import codingstandards.cpp.Identifiers
 
 from Struct s, InterestingIdentifiers s2
 where