Deviations: Expand testing for ranges

Ensure begin/end column code works as expected

Author: lcartey

cpp/common/test/deviations/deviations_basic_test/TypeLongDoubleUsed.expected

@@ -10,3 +10,5 @@
 | main.cpp:21:15:21:16 | d6 | Use of long double type. |
 | main.cpp:30:15:30:17 | d10 | Use of long double type. |
 | main.cpp:38:15:38:17 | d14 | Use of long double type. |
+| main.cpp:42:15:42:17 | d15 | Use of long double type. |
+| main.cpp:43:113:43:115 | d18 | Use of long double type. |

cpp/common/test/deviations/deviations_basic_test/main.cpp

@@ -37,5 +37,10 @@ int main(int argc, char **argv) {
   // codeql::autosar_deviation_end(a-0-4-2-deviation)
   long double d14; // NON_COMPLIANT (A0-4-2)
   getX();          // NON_COMPLIANT (A0-1-2)
+
+  // clang-format off
+  long double d15; /* NON_COMPLIANT*/ /* codeql::autosar_deviation_begin(a-0-4-2-deviation) */ long double d16; // COMPLIANT[DEVIATED]
+  long double d17; /* COMPLIANT[DEVIATED] */ /* codeql::autosar_deviation_end(a-0-4-2-deviation) */ long double d18; // NON_COMPLIANT
+  // clang-format on
   return 0;
 }

cpp/common/test/deviations/deviations_report_deviated/TypeLongDoubleUsed.expected

@@ -0,0 +1,18 @@
+| main.cpp:11:15:11:16 | d1 | Use of long double type. |
+| main.cpp:12:15:12:16 | d2 | Use of long double type. |
+| main.cpp:14:15:14:16 | d3 | Use of long double type. |
+| main.cpp:16:15:16:16 | d4 | Use of long double type. |
+| main.cpp:18:15:18:16 | d5 | Use of long double type. |
+| main.cpp:19:15:19:16 | d6 | Use of long double type. |
+| main.cpp:22:15:22:16 | d7 | Use of long double type. |
+| main.cpp:24:15:24:16 | d8 | Use of long double type. |
+| main.cpp:26:15:26:16 | d9 | Use of long double type. |
+| main.cpp:28:15:28:17 | d10 | Use of long double type. |
+| main.cpp:30:15:30:17 | d11 | Use of long double type. |
+| main.cpp:32:15:32:17 | d12 | Use of long double type. |
+| main.cpp:34:15:34:17 | d13 | Use of long double type. |
+| main.cpp:36:15:36:17 | d14 | Use of long double type. |
+| main.cpp:40:15:40:17 | d15 | Use of long double type. |
+| main.cpp:40:108:40:110 | d16 | Use of long double type. |
+| main.cpp:41:15:41:17 | d17 | Use of long double type. |
+| main.cpp:41:113:41:115 | d18 | Use of long double type. |

cpp/common/test/deviations/deviations_report_deviated/TypeLongDoubleUsed.ql

@@ -0,0 +1,38 @@
+/**
+ * @id cpp/autosar/type-long-double-used
+ * @name A0-4-2: Type long double shall not be used
+ * @description The type long double has an implementation-defined width and therefore shall not be
+ *              used.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity warning
+ * @tags external/autosar/id/a0-4-2
+ *       correctness
+ *       readability
+ *       external/autosar/allocated-target/implementation
+ *       external/autosar/enforcement/automated
+ *       external/autosar/obligation/required
+ */
+
+import cpp
+import codingstandards.cpp.CodingStandards
+import codingstandards.cpp.exclusions.cpp.RuleMetadata
+
+predicate isUsingLongDouble(ClassTemplateInstantiation c) {
+  c.getATemplateArgument() instanceof LongDoubleType or
+  isUsingLongDouble(c.getATemplateArgument())
+}
+
+from Variable v
+where
+  not isExcluded(v, BannedTypesPackage::typeLongDoubleUsedQuery()) and
+  (
+    v.getUnderlyingType() instanceof LongDoubleType and
+    not v.isFromTemplateInstantiation(_)
+    or
+    exists(ClassTemplateInstantiation c |
+      c = v.getType() and
+      isUsingLongDouble(c)
+    )
+  )
+select v, "Use of long double type."