Merge pull request #322 from github/lcartey/fix-range-based-for-loops

`M8-0-1`/`A7-1-5`: Exclude compiler generated DeclStmts

Author: lcartey

change_notes/2023-07-04-remove-compiler-generated-vars.md

@@ -0,0 +1,2 @@
+ * `A7-1-5` - exclude compiler generated variables, such as those generated by for loops.
+ * `M8-0-1` - exclude compiler generated variables, such as those generated by for loops.

cpp/autosar/src/rules/A7-1-5/AutoSpecifierNotUsedAppropriatelyInVariableDefinition.ql

@@ -34,6 +34,8 @@ where
     v.getInitializer().getExpr() instanceof LambdaExpression
     or
     v.getInitializer().getExpr() instanceof ClassAggregateLiteral
-  )
+  ) and
+  // Exclude compiler generated variables
+  not v.isCompilerGenerated()
 select v,
   "Use of auto in variable definition is not the result of a function call, lambda expression, or non-fundamental type initializer."

cpp/autosar/src/rules/M8-0-1/MultipleLocalDeclarators.ql

@@ -20,5 +20,7 @@ import codingstandards.cpp.autosar
 from DeclStmt ds
 where
   not isExcluded(ds, InitializationPackage::multipleLocalDeclaratorsQuery()) and
-  count(ds.getADeclaration()) > 1
+  count(Declaration d | d = ds.getADeclaration()) > 1 and
+  // Not a compiler generated `DeclStmt`, such as in the range-based for loop
+  not ds.isCompilerGenerated()
 select ds, "Declaration list contains more than one declaration."

cpp/autosar/test/rules/A7-1-5/AutoSpecifierNotUsedAppropriatelyInVariableDefinition.expected

@@ -4,3 +4,4 @@
 | test.cpp:27:8:27:8 | a | Use of auto in variable definition is not the result of a function call, lambda expression, or non-fundamental type initializer. |
 | test.cpp:28:8:28:8 | b | Use of auto in variable definition is not the result of a function call, lambda expression, or non-fundamental type initializer. |
 | test.cpp:81:10:81:10 | a | Use of auto in variable definition is not the result of a function call, lambda expression, or non-fundamental type initializer. |
+| test.cpp:111:19:111:19 | a | Use of auto in variable definition is not the result of a function call, lambda expression, or non-fundamental type initializer. |

cpp/autosar/test/rules/A7-1-5/test.cpp

@@ -105,4 +105,10 @@ void instantiate() {
   Test_381<int> t381;
   t381.test_381_1();
   t381.test_381_2();
+}
+
+void test_loop() {
+  for (const auto a : {8, 9, 10}) {
+    a;
+  }
 }

cpp/autosar/test/rules/M8-0-1/test.cpp

@@ -15,3 +15,10 @@ class ClassA {
   int m1, m2; // NON_COMPLIANT
   int m3;     // COMPLIANT
 };
+
+#include <vector>
+void test_loop(std::vector<ClassA> v) {
+  for (const auto b : v) { // COMPLIANT - DeclStmt is compiler generated
+    b;
+  }
+}