Improved test cases

Author: mbaluda

c/misra/src/rules/RULE-12-2/RightHandOperandOfAShiftRange.ql

@@ -29,4 +29,4 @@ where
     lowerBound(right) < 0 or
     upperBound(right) > max_val
   )
-select right, "The shift right hand operand shall lie in the range 0 to " + max_val + "."
+select right, "The right hand operand of the shift operator shall lie in the range 0 to " + max_val + "."

c/misra/test/rules/RULE-12-2/RightHandOperandOfAShiftRange.expected

@@ -1,7 +1,10 @@
-| test.c:8:10:8:10 | 8 | The shift right hand operand shall lie in the range 0 to 7. |
-| test.c:10:10:10:14 | ... + ... | The shift right hand operand shall lie in the range 0 to 7. |
-| test.c:11:10:11:14 | ... + ... | The shift right hand operand shall lie in the range 0 to 7. |
-| test.c:15:9:15:9 | 8 | The shift right hand operand shall lie in the range 0 to 7. |
-| test.c:20:9:20:10 | 64 | The shift right hand operand shall lie in the range 0 to 63. |
-| test.c:23:10:23:11 | 10 | The shift right hand operand shall lie in the range 0 to 7. |
-| test.c:24:10:24:11 | 64 | The shift right hand operand shall lie in the range 0 to 7. |
+| test.c:8:10:8:10 | 8 | The right hand operand of the shift operator shall lie in the range 0 to 7. |
+| test.c:9:10:9:11 | - ... | The right hand operand of the shift operator shall lie in the range 0 to 7. |
+| test.c:10:10:10:14 | ... + ... | The right hand operand of the shift operator shall lie in the range 0 to 7. |
+| test.c:11:10:11:14 | ... + ... | The right hand operand of the shift operator shall lie in the range 0 to 7. |
+| test.c:13:21:13:22 | 16 | The right hand operand of the shift operator shall lie in the range 0 to 15. |
+| test.c:16:9:16:9 | 8 | The right hand operand of the shift operator shall lie in the range 0 to 7. |
+| test.c:21:9:21:10 | 64 | The right hand operand of the shift operator shall lie in the range 0 to 63. |
+| test.c:25:10:25:10 | 8 | The right hand operand of the shift operator shall lie in the range 0 to 7. |
+| test.c:26:10:26:11 | 64 | The right hand operand of the shift operator shall lie in the range 0 to 7. |
+| test.c:30:16:30:17 | 64 | The right hand operand of the shift operator shall lie in the range 0 to 63. |

c/misra/test/rules/RULE-12-2/test.c

@@ -1,25 +1,31 @@
+#include <limits.h>
 #include <stdint.h>
-
 void f1() {
   uint8_t ui8;
   int b = 4;
 
-  ui8 << 7;            // COMPLIANT
-  ui8 >> 8;            // NON_COMPLIANT
-  ui8 << 3 + 3;        // COMPLIANT
-  ui8 >> 4 + b;        // NON_COMPLIANT
-  ui8 << b + b;        // NON_COMPLIANT
-  (uint16_t) ui8 << 9; // COMPLIANT
+  ui8 << 7;             // COMPLIANT
+  ui8 >> 8;             // NON_COMPLIANT
+  ui8 >> -1;            // NON_COMPLIANT
+  ui8 >> 4 + b;         // NON_COMPLIANT
+  ui8 << b + b;         // NON_COMPLIANT
+  (uint16_t) ui8 << 8;  // COMPLIANT
+  (uint16_t) ui8 << 16; // NON_COMPLIANT
 
   // 0u essential type is essentially unsigned char
   0u << 8;           // NON_COMPLIANT
   (uint16_t)0u << 8; // COMPLIANT
 
   unsigned long ul;
-  ul << 10; // COMPLIANT
+  ul << 8;  // COMPLIANT
   ul << 64; // NON_COMPLIANT
 
-  // 1UL essential type is essentially unsigned long
-  1UL << 10; // COMPLIANT[FALSE_POSITIVE]
-  1UL << 64; // NON_COMPLIANT
+  // 1UL essential type is essentially unsigned char
+  1UL << 7;        // COMPLIANT
+  1UL << 8;        // NON_COMPLIANT
+  1UL << 64;       // NON_COMPLIANT
+
+  // ULONG_MAX essential type is essentially unsigned long
+  ULONG_MAX << 8;  // COMPLIANT
+  ULONG_MAX << 64; // NON_COMPLIANT
 }