Merge branch 'main' into jsinglet/automation-check-shared-rules

Author: jsinglet

c/common/test/rules/deadcode/DeadCode.expected

@@ -0,0 +1,11 @@
+| test.c:18:3:18:27 | declaration | This statement is dead code. |
+| test.c:19:3:19:12 | ExprStmt | This statement is dead code. |
+| test.c:20:3:20:12 | ExprStmt | This statement is dead code. |
+| test.c:22:3:24:3 | if (...) ...  | This statement is dead code. |
+| test.c:34:3:35:3 | if (...) ...  | This statement is dead code. |
+| test.c:37:3:37:4 | { ... } | This statement is dead code. |
+| test.c:38:3:40:3 | { ... } | This statement is dead code. |
+| test.c:54:6:55:3 | { ... } | This statement is dead code. |
+| test.c:65:46:66:3 | { ... } | This statement is dead code. |
+| test.c:69:3:69:8 | ExprStmt | This statement is dead code. |
+| test.c:71:3:71:21 | ExprStmt | This statement is dead code. |

c/common/test/rules/deadcode/DeadCode.ql

@@ -0,0 +1,2 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.deadcode.DeadCode

c/common/test/rules/deadcode/test.c

@@ -0,0 +1,74 @@
+// NOTICE: THE TEST CASES BELOW ARE ALSO INCLUDED IN THE C++ TEST CASE AND
+// CHANGES SHOULD BE REFLECTED THERE AS WELL.
+#include <stdbool.h>
+
+int may_have_side_effects();
+int no_side_effects(int x) { return 1 + 2; }
+int no_side_effects_nondeterministic();
+
+int test_dead_code(int x) {
+  int live1 = may_have_side_effects(),
+      live2 = may_have_side_effects(); // COMPLIANT
+  int live3 = 0,
+      live4 = may_have_side_effects(); // COMPLIANT
+  int live5 = 0, live6 = 0;            // COMPLIANT
+  live5 = 1;                           // COMPLIANT
+  live6 = 2;                           // COMPLIANT
+
+  int dead1 = 0, dead2 = 0; // NON_COMPLIANT
+  dead1 = 1;                // NON_COMPLIANT - useless assignment
+  dead2 = 1;                // NON_COMPLIANT - useless assignment
+
+  if (false) {  // NON_COMPLIANT
+    dead2 = 10; // Only used in dead or unreachable code
+  }
+
+  if (true) { // COMPLIANT
+    may_have_side_effects();
+  }
+
+  if (may_have_side_effects()) { // COMPLIANT
+    may_have_side_effects();
+  }
+
+  if (true) { // NON_COMPLIANT
+  }
+
+  {} // NON_COMPLIANT
+  {  // NON_COMPLIANT
+    1 + 2;
+  }
+
+  { // COMPLIANT
+    may_have_side_effects();
+  }
+
+  do { // COMPLIANT
+    may_have_side_effects();
+  } while (may_have_side_effects());
+
+  do { // COMPLIANT
+    may_have_side_effects();
+  } while (may_have_side_effects());
+
+  do { // NON_COMPLIANT
+  } while (no_side_effects_nondeterministic());
+
+  while (may_have_side_effects()) { // COMPLIANT
+    may_have_side_effects();
+  }
+
+  while (may_have_side_effects()) { // COMPLIANT
+    may_have_side_effects();
+  }
+
+  while (no_side_effects_nondeterministic()) { // NON_COMPLIANT
+  }
+
+  may_have_side_effects(); // COMPLIANT
+  1 + 2;                   // NON_COMPLIANT
+
+  no_side_effects(x); // NON_COMPLIANT
+
+  return live5 + live6; // COMPLIANT
+}

c/common/test/rules/unreachablecode/UnreachableCode.expected

@@ -0,0 +1,2 @@
+| test.c:17:3:17:12 | declaration | This statement in function $@ is unreachable. | test.c:15:5:15:21 | test_after_return | test_after_return |
+| test.c:21:10:22:12 | { ... } | This statement in function $@ is unreachable. | test.c:20:5:20:27 | test_constant_condition | test_constant_condition |

c/common/test/rules/unreachablecode/UnreachableCode.ql

@@ -0,0 +1,2 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.unreachablecode.UnreachableCode

c/common/test/rules/unreachablecode/test.c

@@ -0,0 +1,26 @@
+// NOTICE: THE TEST CASES BELOW ARE ALSO INCLUDED IN THE C++ TEST CASE AND
+// CHANGES SHOULD BE REFLECTED THERE AS WELL.
+
+void test_switch(int p1) {
+  int l1 = 0;
+  switch (p1) {
+    l1 = p1; // NON_COMPLIANT[FALSE_NEGATIVE]
+  case 1:
+    break;
+  default:
+    break;
+  }
+}
+
+int test_after_return() {
+  return 0;
+  int l1 = 0; // NON_COMPLIANT - function has returned by this point
+}
+
+int test_constant_condition() {
+  if (0) { // NON_COMPLIANT
+    return 1;
+  } else { // COMPLIANT
+    return 2;
+  }
+}

c/common/test/rules/unusedparameter/UnusedParameter.expected

@@ -0,0 +1 @@
+| test.c:6:22:6:22 | x | Unused parameter 'x' for function $@. | test.c:6:6:6:16 | test_unused | test_unused |

c/common/test/rules/unusedparameter/UnusedParameter.ql

@@ -0,0 +1,2 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.unusedparameter.UnusedParameter

c/common/test/rules/unusedparameter/test.c

@@ -0,0 +1,8 @@
+// NOTICE: THE TEST CASES BELOW ARE ALSO INCLUDED IN THE C++ TEST CASE AND
+// CHANGES SHOULD BE REFLECTED THERE AS WELL.
+
+int test_used(int x) { return x; } // COMPLIANT
+
+void test_unused(int x) {} // NON_COMPLIANT
+
+void test_no_def(int x); // COMPLIANT - no definition, so cannot be "unused"

c/common/test/rules/unusedtypedeclarations/UnusedTypeDeclarations.expected

@@ -0,0 +1,5 @@
+| file://:0:0:0:0 | __va_list_tag | Type declaration __va_list_tag is not used. |
+| test.c:4:8:4:8 | A | Type declaration A is not used. |
+| test.c:7:18:7:18 | D | Type declaration D is not used. |
+| test.c:28:11:28:11 | R | Type declaration R is not used. |
+| test.c:41:12:41:12 | struct <unnamed> | Type declaration struct <unnamed> is not used. |