Ensure Config::resolvesTypedefs() enforced, remove comments

Author: MichaelRFairhurst

c/misra/src/rules/RULE-8-4/CompatibleDeclarationFunctionDefined.ql

@@ -52,12 +52,10 @@ where
         not FunctionDeclarationTypeEquivalence<TypesCompatibleConfig, interestedInFunctions/2>::equalReturnTypes(f1,
           f2)
         or
-        //not compatibleReturns(f1, f2)
         //parameter types differ
         not FunctionDeclarationTypeEquivalence<TypesCompatibleConfig, interestedInFunctions/2>::equalParameterTypes(f1,
           f2)
         or
-        //not compatibleParams(f1, f2)
         //parameter names differ
         parameterNamesUnmatched(f1, f2)
       )

cpp/common/src/codingstandards/cpp/types/Compatible.qll

@@ -390,8 +390,6 @@ module TypeEquivalence<TypeEquivalenceSig Config, interestedInEquality/2 interes
         or
         equalDerivedTypes(t1, t2)
         or
-        equalTypedefTypes(t1, t2)
-        or
         equalFunctionTypes(t1, t2)
         or
         Config::resolveTypedefs() and
@@ -400,6 +398,9 @@ module TypeEquivalence<TypeEquivalenceSig Config, interestedInEquality/2 interes
           or
           equalTypes(t1, t2.(TypedefType).getBaseType())
         )
+        or
+        not Config::resolveTypedefs() and
+        equalTypedefTypes(t1, t2)
       )
     )
   }