Migrate A17-1-1 to use StandardLibraryNames

Author: lcartey

cpp/autosar/src/rules/A17-1-1/CStandardLibraryFunctionCalls.ql

@@ -16,52 +16,25 @@
 
 import cpp
 import codingstandards.cpp.autosar
-import codingstandards.cpp.Naming
+import codingstandards.cpp.StandardLibraryNames
 import codingstandards.cpp.StdNamespace
 
 FunctionCall nonCompliantCStdlibCalls(File f) {
   result =
-    any(FunctionCall fc, string name, string qname, int qname_count |
+    any(FunctionCall fc, Function function, string name |
       f = fc.getFile() and
-      name = fc.getTarget().getName() and
-      Naming::Cpp14::hasStandardLibraryFunctionName(name) and
-      qname = Naming::Cpp14::getQualifiedStandardLibraryFunctionName(name) and
-      qname_count = count(Naming::Cpp14::getQualifiedStandardLibraryFunctionName(name)) and
+      function = fc.getTarget() and
+      name = function.getName() and
+      // Has a name from the C99 library
+      CStandardLibrary::C99::hasFunctionName(_, "", "", name, _, _, _) and
+      // The C function is either declared in the global namespace and imported into std or vice versa
       (
-        not exists(fc.getQualifier()) and
-        (
-          // the set `q` can contain qualified names both with and without the `std` namespace.
-          // in this case, only a call to the function within the `std` namespace is compliant.
-          qname_count > 1 and
-          not exists(NameQualifier nq |
-            nq = fc.getNameQualifier() and nq.getQualifyingElement().getName() = "std"
-          )
-          or
-          // if the qualified standard library function name does not specify a namespace, then the
-          // standard library function is either in the global namespace (such as in C) or within
-          // the `std` namespace. therefore, ignore calls with qualifiers other than 'std'.
-          name = qname and
-          qname_count <= 1 and
-          (
-            not exists(fc.getNameQualifier()) and
-            // also handle implicit namespace scope
-            not exists(Namespace caller_ns, Namespace callee_ns |
-              caller_ns = fc.getEnclosingFunction().getNamespace() and
-              callee_ns = fc.getTarget().getNamespace() and
-              not callee_ns instanceof GlobalNamespace and
-              caller_ns = callee_ns
-            )
-            or
-            exists(NameQualifier nq |
-              nq = fc.getNameQualifier() and
-              (
-                nq.getQualifyingElement() instanceof GlobalNamespace or
-                nq.getQualifyingElement() instanceof StdNS
-              )
-            )
-          )
-        )
-      )
+        function.getNamespace() instanceof StdNS
+        or
+        function.getNamespace() instanceof GlobalNamespace
+      ) and
+      // No function qualifier
+      not exists(fc.getQualifier())
     |
       fc
     )