Fix new query addition

Author: rak3-sh

cpp/autosar/src/rules/M0-1-10/UnusedSplMemberFunction.ql

@@ -2,8 +2,7 @@
  * @id cpp/autosar/unused-spl-member-function
  * @name M0-1-10: Every defined function should be called at least once
  * @description Uncalled functions complicate the program and can indicate a possible mistake on the
- *              part of the programmer. This query specifically looks for unused Special Member
- *              Functions.
+ *              part of the programmer.
  * @kind problem
  * @precision medium
  * @problem.severity warning
@@ -21,7 +20,7 @@ import codingstandards.cpp.deadcode.UnusedFunctions
 
 from UnusedFunctions::UnusedSplMemberFunction unusedSplMemFunction, string name
 where
-  not isExcluded(unusedSplMemFunction, DeadCodePackage::unusedFunctionQuery()) and
+  not isExcluded(unusedSplMemberFunctionQuery, DeadCodePackage::unusedFunctionQuery()) and
   (
     if exists(unusedSplMemFunction.getQualifiedName())
     then name = unusedSplMemFunction.getQualifiedName()

cpp/autosar/test/rules/M0-1-10/UnusedSplMemberFunction.qlref

@@ -1 +1 @@
-rules/M0-1-10/UnusedSplMemberFunction.ql
+rules/M0-1-10/UnusedSplMemberFunction.ql

cpp/common/src/codingstandards/cpp/exclusions/cpp/DeadCode.qll

@@ -12,6 +12,7 @@ newtype DeadCodeQuery =
   TUnusedTypeDeclarationsQuery() or
   TUnreachableCodeQuery() or
   TUnusedFunctionQuery() or
+  TUnusedSplMemberFunctionQuery() or
   TInfeasiblePathQuery() or
   TUnusedLocalVariableQuery() or
   TUnusedGlobalOrNamespaceVariableQuery() or
@@ -94,6 +95,15 @@ predicate isDeadCodeQueryMetadata(Query query, string queryId, string ruleId, st
   ruleId = "M0-1-10" and
   category = "advisory"
   or
+  query =
+    // `Query` instance for the `unusedSplMemberFunction` query
+    DeadCodePackage::unusedSplMemberFunctionQuery() and
+  queryId =
+    // `@id` for the `unusedSplMemberFunction` query
+    "cpp/autosar/unused-spl-member-function" and
+  ruleId = "M0-1-10" and
+  category = "advisory"
+  or
   query =
     // `Query` instance for the `infeasiblePath` query
     DeadCodePackage::infeasiblePathQuery() and
@@ -224,6 +234,13 @@ module DeadCodePackage {
       TQueryCPP(TDeadCodePackageQuery(TUnusedFunctionQuery()))
   }
 
+  Query unusedSplMemberFunctionQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `unusedSplMemberFunction` query
+      TQueryCPP(TDeadCodePackageQuery(TUnusedSplMemberFunctionQuery()))
+  }
+
   Query infeasiblePathQuery() {
     //autogenerate `Query` type
     result =

rule_packages/cpp/DeadCode.json

@@ -194,6 +194,21 @@
             "readability",
             "maintainability"
           ]
+        },
+        {
+          "description": "Uncalled functions complicate the program and can indicate a possible mistake on the part of the programmer.",
+          "kind": "problem",
+          "name": "Every defined function should be called at least once",
+          "precision": "medium",
+          "severity": "warning",
+          "short_name": "UnusedSplMemberFunction",
+          "tags": [
+            "readability",
+            "maintainability"
+          ],
+          "implementation_scope": {
+            "description": "In limited cases, this query can raise false-positives for special member function calls invoked from the C++ Metaprogramming library."
+          }
         }
       ],
       "title": "Every defined function should be called at least once."