M17-0-3: Migrate to StandardNaming

Author: lcartey

change_notes/2025-08-28-naming.md

@@ -0,0 +1,3 @@
+ - `M17-0-3` - `NameOfStandardLibraryFunctionIsOverridden.ql`:
+   - The list of standard library names has been refined.
+   - Only names defined in the global namespace by the C++ standard are now reported.

cpp/autosar/src/rules/M17-0-3/NameOfStandardLibraryFunctionIsOverridden.ql

@@ -15,16 +15,26 @@
 
 import cpp
 import codingstandards.cpp.autosar
-import codingstandards.cpp.Naming
+import codingstandards.cpp.StandardLibraryNames
 
-predicate isGlobal(Function f) { f.hasGlobalName(_) }
-
-from TopLevelFunction f
+from TopLevelFunction f, string functionName, string header
 where
   not isExcluded(f, NamingPackage::nameOfStandardLibraryFunctionIsOverriddenQuery()) and
-  Naming::Cpp14::hasStandardLibraryFunctionName(f.getName()) and
-  f.fromSource() and
-  isGlobal(f)
+  f.hasGlobalName(functionName) and
+  /*
+   * The rule does not define what it means by "standard library function", but we will
+   * assume that it is a non-member function which is declared in the global namespace.
+   * Functions declared in `std` only can't be easily "replaced" in the way the rule is
+   * concerned about (without extending 'std'), and so are excluded.
+   */
+
+  (
+    // Directly defined by C++
+    CppStandardLibrary::Cpp14::hasFunctionName(header, "", "", functionName, _, _, _)
+    or
+    // Defined by C and inherited by C++
+    CStandardLibrary::C11::hasFunctionName(header, "", "", functionName, _, _, _)
+  ) and
+  f.fromSource()
 select f,
-  "Function " + f.getName() + " overrides standard library function " +
-    Naming::Cpp14::getQualifiedStandardLibraryFunctionName(f.getName()) + "."
+  "Function " + functionName + " overrides a standard library function from '" + header + "'."

cpp/autosar/test/rules/M17-0-3/NameOfStandardLibraryFunctionIsOverridden.expected

@@ -1,5 +1,3 @@
-| test.cpp:1:6:1:11 | malloc | Function malloc overrides standard library function malloc. |
-| test.cpp:3:6:3:11 | printf | Function printf overrides standard library function printf. |
-| test.cpp:5:6:5:11 | strlen | Function strlen overrides standard library function strlen. |
-| test.cpp:7:6:7:8 | end | Function end overrides standard library function std::__1::end. |
-| test.cpp:7:6:7:8 | end | Function end overrides standard library function std::end. |
+| test.cpp:1:6:1:11 | malloc | Function malloc overrides a standard library function from 'stdlib.h'. |
+| test.cpp:3:6:3:11 | printf | Function printf overrides a standard library function from 'stdio.h'. |
+| test.cpp:5:6:5:11 | strlen | Function strlen overrides a standard library function from 'string.h'. |

cpp/autosar/test/rules/M17-0-3/test.cpp

@@ -4,4 +4,4 @@ void printf() {} // NON_COMPLIANT
 
 void strlen() {} // NON_COMPLIANT
 
-void end() {} // NON_COMPLIANT
+void end() {} // COMPLIANT - end is in the std namespace

rule_packages/cpp/Naming.json

@@ -268,7 +268,10 @@
           "tags": [
             "readability",
             "maintainability"
-          ]
+          ],
+          "implementation_scope": {
+            "description": "This implementation reports all functions with the same name as a function declared in the global namespace in the C++ standard."
+          }
         }
       ],
       "title": "The names of standard library functions shall not be overridden."