Rule 14.3: Improve alert message

Author: lcartey

c/misra/src/rules/RULE-14-3/ControllingExprInvariant.ql

@@ -31,7 +31,7 @@ where
         )
       )
     ) and
-    message = "Controlling expression in if statement has invariant value."
+    message = "Controlling expression in if statement has an invariant value."
     or
     exists(Loop loop |
       loop.getControllingExpr() = expr and
@@ -47,7 +47,7 @@ where
         not expr instanceof Literal
       )
     ) and
-    message = "Controlling expression in loop statement has invariant value."
+    message = "Controlling expression in loop statement has an invariant value."
     or
     exists(SwitchStmt switch |
       switch.getControllingExpr() = expr and
@@ -56,7 +56,7 @@ where
         conditionAlwaysTrue(expr)
       )
     ) and
-    message = "Controlling expression in switch statement has invariant value."
+    message = "Controlling expression in switch statement has an invariant value."
     or
     exists(ConditionalExpr conditional |
       conditional.getCondition() = expr and
@@ -65,7 +65,7 @@ where
         conditionAlwaysTrue(expr)
       )
     ) and
-    message = "Controlling expression in conditional statement has invariant value."
+    message = "Controlling expression in conditional statement has an invariant value."
   ) and
   // Exclude cases where the controlling expressions is affected by a macro, because they can appear
   // invariant in a particular invocation, but be variant between invocations.

c/misra/test/rules/RULE-14-3/ControllingExprInvariant.expected

@@ -1,7 +1,7 @@
-| test.c:4:7:4:11 | ... > ... | Controlling expression in if statement has invariant value. |
-| test.c:15:10:15:16 | ... > ... | Controlling expression in loop statement has invariant value. |
-| test.c:16:9:16:13 | ... > ... | Controlling expression in if statement has invariant value. |
-| test.c:20:20:20:24 | ... < ... | Controlling expression in loop statement has invariant value. |
-| test.c:27:10:27:14 | ... < ... | Controlling expression in loop statement has invariant value. |
-| test.c:37:3:37:6 | 1 | Controlling expression in conditional statement has invariant value. |
-| test.c:38:3:38:3 | 1 | Controlling expression in conditional statement has invariant value. |
+| test.c:4:7:4:11 | ... > ... | Controlling expression in if statement has an invariant value. |
+| test.c:15:10:15:16 | ... > ... | Controlling expression in loop statement has an invariant value. |
+| test.c:16:9:16:13 | ... > ... | Controlling expression in if statement has an invariant value. |
+| test.c:20:20:20:24 | ... < ... | Controlling expression in loop statement has an invariant value. |
+| test.c:27:10:27:14 | ... < ... | Controlling expression in loop statement has an invariant value. |
+| test.c:37:3:37:6 | 1 | Controlling expression in conditional statement has an invariant value. |
+| test.c:38:3:38:3 | 1 | Controlling expression in conditional statement has an invariant value. |