Declarations3: add shared RULE-8-1

Author: knewbury01

c/cert/src/rules/DCL31-C/DeclareIdentifiersBeforeUsingThem.md

@@ -153,7 +153,7 @@ Search for [vulnerabilities](https://wiki.sei.cmu.edu/confluence/display/c/BB.+D
 
 ## Implementation notes
 
-This query does not check for implicit function declarations as this is partially compiler checked.
+This query does not check for implicitly typed parameters, typedefs or member declarations as this is partially compiler checked.
 
 ## References
 

c/cert/src/rules/DCL31-C/DeclareIdentifiersBeforeUsingThem.ql

@@ -13,16 +13,10 @@
 
 import cpp
 import codingstandards.c.cert
+import codingstandards.cpp.rules.typeomitted.TypeOmitted
 
-from Declaration d
-where
-  not isExcluded(d, Declarations1Package::declareIdentifiersBeforeUsingThemQuery()) and
-  d.hasSpecifier("implicit_int") and
-  exists(Type t |
-    (d.(Variable).getType() = t or d.(Function).getType() = t) and
-    // Exclude "short" or "long", as opposed to "short int" or "long int".
-    t instanceof IntType and
-    // Exclude "signed" or "unsigned", as opposed to "signed int" or "unsigned int".
-    not exists(IntegralType it | it = t | it.isExplicitlySigned() or it.isExplicitlyUnsigned())
-  )
-select d, "Declaration " + d.getName() + " is missing a type specifier."
+class DeclareIdentifiersBeforeUsingThem extends TypeOmittedSharedQuery {
+  DeclareIdentifiersBeforeUsingThem() {
+    this = Declarations1Package::declareIdentifiersBeforeUsingThemQuery()
+  }
+}

c/cert/test/rules/DCL31-C/DeclareIdentifiersBeforeUsingThem.qlref

@@ -0,0 +1 @@
+c/common/test/rules/typeomitted/TypeOmitted.ql

c/cert/test/rules/DCL31-C/DeclareIdentifiersBeforeUsingThem.testref

@@ -0,0 +1,2 @@
+// GENERATED FILE - DO NOT MODIFY
+import codingstandards.cpp.rules.typeomitted.TypeOmitted

c/cert/test/rules/DCL31-C/DeclareIdentifiersBeforeUsingThem.expected renamed to c/common/test/rules/typeomitted/TypeOmitted.expected

@@ -13,3 +13,13 @@ int f1(void) { // COMPLIANT
 short g2;                 // COMPLIANT
 long g3;                  // COMPLIANT
 signed g4() { return 1; } // COMPLIANT
+
+typedef *newtype3; // NON_COMPLIANT[FALSE_NEGATIVE]
+
+int f2(const x) { // NON_COMPLIANT[FALSE_NEGATIVE]
+  return 1;
+}
+
+struct str {
+  const y; // NON_COMPLIANT[FALSE_NEGATIVE]
+} s;

c/common/test/rules/typeomitted/TypeOmitted.ql

@@ -0,0 +1,20 @@
+/**
+ * @id c/misra/explicitly-declare-types
+ * @name RULE-8-1: Declare identifiers before using them
+ * @description Omission of type specifiers may not be supported by some compilers.
+ * @kind problem
+ * @precision very-high
+ * @problem.severity error
+ * @tags external/misra/id/rule-8-1
+ *       correctness
+ *       readability
+ *       external/misra/obligation/required
+ */
+
+import cpp
+import codingstandards.c.misra
+import codingstandards.cpp.rules.typeomitted.TypeOmitted
+
+class ExplicitlyDeclareTypesQuery extends TypeOmittedSharedQuery {
+  ExplicitlyDeclareTypesQuery() { this = Declarations3Package::explicitlyDeclareTypesQuery() }
+}

c/cert/test/rules/DCL31-C/test.c renamed to c/common/test/rules/typeomitted/test.c

@@ -0,0 +1 @@
+c/common/test/rules/typeomitted/TypeOmitted.ql

c/misra/src/rules/RULE-8-1/ExplicitlyDeclareTypes.ql

@@ -7,7 +7,8 @@ newtype Declarations3Query =
   TIdentifierHidingCQuery() or
   TIdentifiersNotDistinctFromMacroNamesQuery() or
   TTypedefNameNotUniqueQuery() or
-  TTagNameNotUniqueQuery()
+  TTagNameNotUniqueQuery() or
+  TExplicitlyDeclareTypesQuery()
 
 predicate isDeclarations3QueryMetadata(Query query, string queryId, string ruleId) {
   query =
@@ -41,6 +42,14 @@ predicate isDeclarations3QueryMetadata(Query query, string queryId, string ruleI
     // `@id` for the `tagNameNotUnique` query
     "c/misra/tag-name-not-unique" and
   ruleId = "RULE-5-7"
+  or
+  query =
+    // `Query` instance for the `explicitlyDeclareTypes` query
+    Declarations3Package::explicitlyDeclareTypesQuery() and
+  queryId =
+    // `@id` for the `explicitlyDeclareTypes` query
+    "c/misra/explicitly-declare-types" and
+  ruleId = "RULE-8-1"
 }
 
 module Declarations3Package {
@@ -71,4 +80,11 @@ module Declarations3Package {
       // `Query` type for `tagNameNotUnique` query
       TQueryC(TDeclarations3PackageQuery(TTagNameNotUniqueQuery()))
   }
+
+  Query explicitlyDeclareTypesQuery() {
+    //autogenerate `Query` type
+    result =
+      // `Query` type for `explicitlyDeclareTypes` query
+      TQueryC(TDeclarations3PackageQuery(TExplicitlyDeclareTypesQuery()))
+  }
 }