Don't report '//*comment' in RULE-3-1

Author: MichaelRFairhurst

c/misra/src/rules/RULE-3-1/CharacterSequencesAndUsedWithinAComment.ql

@@ -43,7 +43,7 @@ where
   not isExcluded(comment, SyntaxPackage::characterSequencesAndUsedWithinACommentQuery()) and
   (
     exists(IllegalCommentSequence c | illegalSequence = c |
-      comment.getContents().indexOf(illegalSequence) > 0
+      comment.getContents().indexOf(illegalSequence) > 1
     )
     or
     exists(IllegalCCommentRegexp c | illegalSequence = c.getDescription() |

c/misra/test/rules/RULE-3-1/CharacterSequencesAndUsedWithinAComment.expected

@@ -3,3 +3,4 @@
 | test.c:21:1:21:7 | //  /*  | Comment contains an illegal sequence '/*' |
 | test.c:30:1:30:27 | /* https://github.com // */ | Comment contains an illegal sequence '//' |
 | test.c:33:1:33:60 | /* a://b, a://b., ://a.b, a://b., a://.b, ://, a://, ://b */ | Comment contains an illegal sequence '//' |
+| test.c:42:1:42:8 | ///* foo | Comment contains an illegal sequence '/*' |

c/misra/test/rules/RULE-3-1/test.c

@@ -35,4 +35,10 @@
 // COMPLIANT
 // https://github.com
 
+// COMPLIANT
+//* foo
+
+// NON_COMPLIANT
+///* foo
+
 void f(){}

change_notes/2024-12-13-implement-misra-c-amendment4-rule-amendments.md

@@ -7,4 +7,5 @@
  - `RULE-13-2` - `UnsequencedAtomicReads.ql`
    - New query to find expressions which read an atomic variable more than once between sequence points, to address new case from MISRA-C 2012 Amendment 4.
  - `RULE-3-1` - `CharacterSequencesAndUsedWithinAComment.ql`
-   - Add exception allowing URLs inside of cpp-style `/* ... */` comments, in compliance with MISRA-C 2012 Amendment 4
+   - Add exception allowing URLs inside of cpp-style `/* ... */` comments, in compliance with MISRA-C 2012 Amendment 4.
+   - No longer report cases of `//*some comment` in this rule.