Merge pull request #304 from mbaluda/cpp-qcc-compile

Pass all `c++` tests when compiled with `qcc`

Author: lcartey

change_notes/2023-05-22-pass-compiler-tests-qcc.md

@@ -21,7 +21,7 @@ import codingstandards.cpp.autosar
 import codingstandards.cpp.TypeUses
 
 class NumericLimits extends Class {
-  NumericLimits() { this.hasQualifiedName("std", "numeric_limits") }
+  NumericLimits() { this.hasQualifiedName("std", ["numeric_limits", "__libcpp_numeric_limits"]) }
 
   /**
    * Gets the template argument specified for this type.

cpp/autosar/src/rules/A0-4-1/FloatingPointImplementationShallComplyWithIeeeStandard.ql

@@ -20,8 +20,14 @@ from File f, string flag
 where
   not isExcluded(f, ToolchainPackage::compilerImplementationShallComplyWithCPP14StandardQuery()) and
   exists(Compilation c | f = c.getAFileCompiled() |
-    c.getAnArgument() = flag and flag.regexpMatch("-std=(?!c\\+\\+14)[\\w+]+")
-  )
+    flag =
+      max(string std, int index |
+        c.getArgument(index) = std and std.matches("-std=%")
+      |
+        std order by index
+      )
+  ) and
+  flag != "-std=c++14"
 select f,
   "File '" + f.getBaseName() + "' compiled with flag '" + flag +
     "' which does not strictly comply with ISO C++14."

cpp/autosar/src/rules/A0-4-3/CompilerImplementationShallComplyWithCPP14Standard.ql

@@ -14,11 +14,10 @@
 
 import cpp
 import codingstandards.cpp.autosar
-import codingstandards.cpp.TypeUses
 
-from Class c, Locatable l
+from TypeMention l, Class c
 where
   not isExcluded(l, ToolchainPackage::strstreamTypesAreDeprecatedQuery()) and
   c.hasQualifiedName("std", ["strstreambuf", "ostrstream", "istrstream"]) and
-  exists(Type t | t = c | l = getATypeUse(t))
-select l, "Use of <strstream> class '" + c.getQualifiedName() + "' is deprecated."
+  l.getMentionedType() = c
+select l, "Use of <strstream> class '" + c.getName() + "' is deprecated."

cpp/autosar/src/rules/A1-1-1/StrstreamTypesAreDeprecated.ql

@@ -26,7 +26,7 @@ where
     c.getAnArgument() = flag and
     flag =
       [
-        "-Ofast", "-ffast-math", "-fgnu-keywords", "-fno-signed-zeroes", "-fno-signed-zeros", "-menable-unsafe-fp-math",
+        "-Ofast", "-ffast-math", "-fgnu-keywords", "-fno-signed-zeros", "-menable-unsafe-fp-math",
         "-menable-no-nans", "-menable-no-infs", "-menable-unsafe-fp-math", "-ffinite-math-only",
         "-ffloat-store"
       ]

cpp/autosar/src/rules/A1-1-3/UncompliantOptimizationOptionMustBeDisabledInCompiler.ql

@@ -17,6 +17,7 @@
 import cpp
 import codingstandards.cpp.autosar
 import codingstandards.cpp.Naming
+import codingstandards.cpp.StdNamespace
 
 FunctionCall nonCompliantCStdlibCalls(File f) {
   result =
@@ -55,7 +56,7 @@ FunctionCall nonCompliantCStdlibCalls(File f) {
               nq = fc.getNameQualifier() and
               (
                 nq.getQualifyingElement() instanceof GlobalNamespace or
-                nq.getQualifyingElement() instanceof StdNamespace
+                nq.getQualifyingElement() instanceof StdNS
               )
             )
           )

cpp/autosar/src/rules/A17-1-1/CStandardLibraryFunctionCalls.ql

@@ -17,9 +17,10 @@
 
 import cpp
 import codingstandards.cpp.autosar
+import codingstandards.cpp.StdNamespace
 
 predicate isVectorBool(ClassTemplateInstantiation c) {
-  c.getNamespace() instanceof StdNamespace and
+  c.getNamespace() instanceof StdNS and
   c.getTemplateArgument(0) instanceof BoolType and
   c.getSimpleName() = "vector"
 }

cpp/autosar/src/rules/A18-1-2/VectorboolSpecializationUsed.ql

@@ -15,9 +15,10 @@
 
 import cpp
 import codingstandards.cpp.autosar
+import codingstandards.cpp.StdNamespace
 
 predicate isAutoPtr(ClassTemplateInstantiation c) {
-  c.getNamespace() instanceof StdNamespace and
+  c.getNamespace() instanceof StdNS and
   c.getSimpleName() = "auto_ptr"
 }
 

cpp/autosar/src/rules/A18-1-3/AutoPtrTypeUsed.ql

@@ -15,13 +15,15 @@
 
 import cpp
 import codingstandards.cpp.autosar
+import codingstandards.cpp.StdNamespace
 
 predicate isBind(FunctionCall fc) {
-  fc.getTarget().getQualifiedName() in ["std::bind", "std::bind1st", "std::bind2nd"]
+  fc.getTarget().getNamespace() instanceof StdNS and
+  fc.getTarget().getName() in ["bind", "bind1st", "bind2nd"]
 }
 
 from FunctionCall fc
 where
   isBind(fc) and
   not isExcluded(fc, BannedFunctionsPackage::bindUsedQuery())
-select fc, "Prefer lambdas to using " + fc.getTarget().getQualifiedName() + "."
+select fc, "Prefer lambdas to using `" + fc.getTarget().getName() + "`."

cpp/autosar/src/rules/A18-9-1/BindUsed.ql

@@ -26,12 +26,14 @@ predicate isUsingWideCharType(ClassTemplateInstantiation c) {
 
 from Variable v
 where
-  v.getUnderlyingType() instanceof WideCharType and
-  not v.isFromTemplateInstantiation(_)
-  or
-  exists(ClassTemplateInstantiation c |
-    c = v.getType() and
-    isUsingWideCharType(c)
-  ) and
-  not isExcluded(v, BannedTypesPackage::typeWcharTUsedQuery())
+  not isExcluded(v, BannedTypesPackage::typeWcharTUsedQuery()) and
+  (
+    v.getUnderlyingType() instanceof WideCharType and
+    not v.isFromTemplateInstantiation(_)
+    or
+    exists(ClassTemplateInstantiation c |
+      c = v.getType() and
+      isUsingWideCharType(c)
+    )
+  )
 select v, "Use of wchar_t type."