Preprocessor5: improve alert message Rule MSC38-C

Author: knewbury01

c/cert/src/rules/MSC38-C/DoNotTreatAPredefinedIdentifierAsObject.ql

@@ -33,15 +33,13 @@ predicate hasRestrictedMacroName(string s) {
   s = "va_start"
 }
 
-from Element m, string name, string condition
+from Element m, string name
 where
   not isExcluded(m, Preprocessor5Package::doNotTreatAPredefinedIdentifierAsObjectQuery()) and
   (
-    condition = "Access" and
     m.(Access).getTarget().hasName(name)
     or
-    m.(Declaration).hasGlobalName(name) and
-    condition = "Redefinition"
+    m.(Declaration).hasGlobalName(name)
   ) and
   hasRestrictedMacroName(name)
-select m, condition + " of standard library macro " + name + "."
+select m, "Supression of standard library macro " + name + "."

c/cert/test/rules/MSC38-C/DoNotTreatAPredefinedIdentifierAsObject.expected

@@ -1,2 +1,2 @@
-| test.c:3:12:3:16 | errno | Redefinition of standard library macro errno. |
-| test.c:10:21:10:26 | assert | Access of standard library macro assert. |
+| test.c:3:12:3:16 | errno | Supression of standard library macro errno. |
+| test.c:10:21:10:26 | assert | Supression of standard library macro assert. |