work

Author: jsinglet

c/misra/src/rules/RULE-1-2/LanguageExtensionsShouldNotBeUsed.ql

@@ -14,8 +14,9 @@
 
 import cpp
 import codingstandards.c.misra
+import codingstandards.c.Extensions
 
-from
+from CCompilerExtension e
 where
-  not isExcluded(x, Language2Package::languageExtensionsShouldNotBeUsedQuery()) and
-select
+  not isExcluded(e, Language2Package::languageExtensionsShouldNotBeUsedQuery()) 
+select e, "Is a compiler extension and is not portable to other compilers." 

c/misra/test/rules/RULE-1-2/test.c

@@ -9,6 +9,7 @@
 // - https://clang.llvm.org/docs/LanguageExtensions.html
 // - https://gcc.gnu.org/onlinedocs/gcc/C-Extensions.html
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html#Other-Builtins
 #ifdef __has_builtin // NON_COMPLIANT
 #endif
 #ifdef __has_constexpr_builtin // NON_COMPLIANT
@@ -32,6 +33,7 @@
 #ifdef __has_warning // NON_COMPLIANT
 #endif
 
+// Reference: https://clang.llvm.org/docs/LanguageExtensions.html#builtin-macros
 #define A __BASE_FILE__                   // NON_COMPLIANT
 #define B __FILE_NAME__                   // NON_COMPLIANT
 #define C __COUNTER__                     // NON_COMPLIANT
@@ -45,24 +47,22 @@
 #define K __clang_literal_encoding__      // NON_COMPLIANT
 #define L __clang_wide_literal_encoding__ // NON_COMPLIANT
 
-typedef float float4 __attribute__((ext_vector_type(4))); // NON_COMPLIANT
-typedef float float2 __attribute__((ext_vector_type(2))); // NON_COMPLIANT
-
 // Requires additional compiler flags to change the architecture
 // typedef __attribute__((neon_vector_type(8))) int8_t int8x8_t;
 // typedef __attribute__((neon_polyvector_type(16))) poly8_t poly8x16_t;
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Variable-Attributes.html#Variable-Attributes
 typedef int int4 __attribute__((vector_size(4 * sizeof(int)))); // NON_COMPLIANT
-
 typedef int v4si __attribute__((__vector_size__(16)));    // NON_COMPLIANT
 typedef float float4 __attribute__((ext_vector_type(4))); // NON_COMPLIANT
 typedef float float2 __attribute__((ext_vector_type(2))); // NON_COMPLIANT
 
-//// GCC features
+
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Statement-Exprs.html#Statement-Exprs
 void gf1() {
-  ({
+  ({ // NON_COMPLIANT
     int y = 1;
-    int z; // NON_COMPLIANT
+    int z; 
     if (y > 0)
       z = y;
     else
@@ -71,149 +71,154 @@ void gf1() {
   });
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Local-Labels.html#Local-Labels
 void gf2() {
-  // __label__ found; -- local labels not supported by clang
+  // __label__ found; // NON_COMPLIANT[FALSE_NEGATIVE] -- local labels not supported by clang
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Labels-as-Values.html#Labels-as-Values
 void gf3() {
   void *ptr;
-  // goto *ptr; -- not supported in clang
+  // goto *ptr; // NON_COMPLIANT[FALSE_NEGATIVE]  -- not supported in clang
 }
 
+// Referfence: https://gcc.gnu.org/onlinedocs/gcc/Nested-Functions.html#Nested-Functions
 void gf4() {
-  // void gf4a(){  -- not supported in clang
+  // void gf4a(){  // NON_COMPLIANT[FALSE_NEGATIVE]  -- not supported in clang
   //
   // }
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Nonlocal-Gotos.html#Nonlocal-Gotos
 void gf5() {
   __builtin_setjmp(0);     // NON_COMPLIANT
   __builtin_longjmp(0, 1); // NON_COMPLIANT
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Constructing-Calls.html#Constructing-Calls
 void gf6() {
   // not supported by clang
-
-  //__builtin_apply_args();
-  //__builtin_apply(0, 0, 0);
-  //__builtin_return(0);
-  //__builtin_va_arg_pack();
-  //__builtin_va_arg_pack_len();
+  //__builtin_apply_args(); // NON_COMPLIANT[FALSE_NEGATIVE] 
+  //__builtin_apply(0, 0, 0); // NON_COMPLIANT[FALSE_NEGATIVE] 
+  //__builtin_return(0); // NON_COMPLIANT[FALSE_NEGATIVE] 
+  //__builtin_va_arg_pack(); // NON_COMPLIANT[FALSE_NEGATIVE] 
+  //__builtin_va_arg_pack_len(); // NON_COMPLIANT[FALSE_NEGATIVE] 
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Conditionals.html#Conditionals
 void gf7() {
   int a = 0 ?: 0; // NON_COMPLIANT
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Typeof.html#Typeof
 void gf8() {
-  typeof(int *); // NON_COMPLIANT
+  typeof(int *); // NON_COMPLIANT[FALSE_NEGATIVE]
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/_005f_005fint128.html#g_t_005f_005fint128
 void gf9() {
   __int128 a; // NON_COMPLIANT
 }
-
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Long-Long.html#Long-Long
 void gf10() {
   long long int a; // NON_COMPLIANT
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Complex.html#Complex
 void gf11() {
-  __real__(0); // NON_COMPLIANT
-  __imag__(0); // NON_COMPLIANT
+  __real__(0); // NON_COMPLIANT[FALSE_NEGATIVE]
+  __imag__(0); // NON_COMPLIANT[FALSE_NEGATIVE]
 }
 
 void gf12() {}
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Floating-Types.html#Floating-Types
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Decimal-Float.html#Decimal-Float
 void gf13() {
   // not supported on clang
-
-  //_Decimal32 a;
-  //_Decimal64 b;
-  //_Decimal128 c;
+  //_Decimal32 a; // NON_COMPLIANT[FALSE_NEGATIVE]
+  //_Decimal64 b; // NON_COMPLIANT[FALSE_NEGATIVE]
+  //_Decimal128 c; // NON_COMPLIANT[FALSE_NEGATIVE]
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Complex.html#Complex
 void gf14() {
-  // Not sure how to get this to work.
-  // typedef _Complex float __attribute__((mode(TC))) _Complex128;
-  // typedef _Complex float __attribute__((mode(XC))) _Complex80;
+  // Do not work in clang
+  // typedef _Complex float __attribute__((mode(TC))) _Complex128; // NON_COMPLIANT[FALSE_NEGATIVE]
+  // typedef _Complex float __attribute__((mode(XC))) _Complex80; // NON_COMPLIANT[FALSE_NEGATIVE]
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Hex-Floats.html#Hex-Floats
 void gf15() {
-  float f = 0x1.fp3; // NON_COMPLIANT 
+  float f = 0x1.fp3; // NON_COMPLIANT[FALSE_NEGATIVE]
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Zero-Length.html#Zero-Length
 void gf16() {
   char contents[0]; // NON_COMPLIANT
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Named-Address-Spaces.html#Named-Address-Spaces
 void gf17() {
-  // const __flash char ** p; // not supported in clang
+  // const __flash char ** p; // NON_COMPLIANT[FALSE_NEGATIVE] --  not supported in clang
 }
 
 void gf18() {
   // not supported by extractor - checked by looking for flags.
 
-  // short _Fract, _Fract;
-  // long _Fract;
+  // short _Fract, _Fract; // NON_COMPLIANT[FALSE_NEGATIVE] -
+  // long _Fract; // NON_COMPLIANT[FALSE_NEGATIVE] 
 }
 
 struct gf19 {}; // NON_COMPLIANT
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Variable-Length.html#Variable-Length
 void gf20(int n) {
-  // struct S { int x[n]; }; // will never be supported in clang
+  // struct S { int x[n]; }; // NON_COMPLIANT[FALSE_NEGATIVE] - will never be supported in clang
 }
-
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Variadic-Macros.html#Variadic-Macros
 #define gf21(format, args...)                                                  \
-  printf(format, args) // NON_COMPLIANT -- note the issue here is explicitly
+  printf(format, args) // NON_COMPLIANT // NON_COMPLIANT[FALSE_NEGATIVE] -- note the issue here is explicitly
                        // naming the arguments.
 #define gf21a(format, ...) printf(format, __VA_ARGS__) // COMPLIANT
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Escaped-Newlines.html#Escaped-Newlines
 #define gf22                                                                   \
   "a"                                                                          \
   \     
-"b" // NON_COMPLIANT - additional spaces after a backslash
+"b" // NON_COMPLIANT[FALSE_NEGATIVE] - additional spaces after a backslash -- stripped by extractor
 #define gf22a                                                                  \
   "a"                                                                          \
   "b" // COMPLIANT
 
-struct gf23s {
-  int a[1];
-};
-struct gf23s gf23f();
-void gf23() {
-  gf23f().a[0]; // NON_COMPLIANT in C90
-}
-
 void gf24(int f, int g) {
   float beat_freqs[2] = {f - g, f + g}; // NON_COMPLIANT
 }
 
-void gf25t(int N, int M, double out[M][N], const double in[N][M]);
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Variable-Length.html#Variable-Length
+void gf25t(int N, int M, double out[M][N], const double in[N][M]); // NON_COMPLIANT[FALSE_NEGATIVE]
 void gf25() {
   double x[3][2];
   double y[2][3];
   gf25t(3, 2, y,
-        x); // NON_COMPLIANT - in ISO C the const qualifier is formally attached
+        x); // in ISO C the const qualifier is formally attached
             // to the element type of the array and not the array itself
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Compound-Literals.html#Compound-Literals
 struct gf26t {
   int a;
   char b[2];
 } gf26v;
 void gf26(int x, int y) {
-  gf26v = ((struct gf26t){x + y, 'z', 0}); // NON_COMPLIANT - compound literal
-}
-
-void gf27() {
-  int a[6] = {[4] = 29, [2] = 15}; // NON_COMPLIANT in C90.
+  gf26v = ((struct gf26t){x + y, 'z', 0}); // NON_COMPLIANT[FALSE_NEGATIVE] - compound literal
 }
-
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Case-Ranges.html#Case-Ranges
 void gf28() {
   int a;
 
   // switch(a){
-  //     case: 0 ... 5:  // Not supported in clang.
+  //     case: 0 ... 5:  // NON_COMPLIANT[FALSE_NEGATIVE] -  Not supported in clang.
   //         ;;
   //         break;
   //     default:
@@ -227,16 +232,19 @@ union gf29u {
   double j;
 };
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Cast-to-Union.html#Cast-to-Union
 void gf29() {
   int x;
   int y;
   union gf29u z;
-  z = (union gf29u)x; // NON_COMPLIANT
-  z = (union gf29u)y; // NON_COMPLIANT
+  z = (union gf29u)x; // NON_COMPLIANT[FALSE_NEGATIVE]
+  z = (union gf29u)y; // NON_COMPLIANT[FALSE_NEGATIVE]
 }
 
-__attribute__((access(read_only, 1))) int
-gf30(const char *); // NON_COMPLIANT -- attributes are not portable.
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Variable-Attributes.html#Variable-Attributes
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Function-Attributes.html#Function-Attributes
+__attribute__((access(read_only, 1))) 
+int gf30(const char *); // NON_COMPLIANT -- attributes are not portable.
 
 extern int __attribute__((alias("var_target")))
 gf31; // NON_COMPLIANT -- attributes are not portable.
@@ -258,7 +266,7 @@ enum gf34 {
 
 void gf35() {
   int x;
-  // __attribute__((assume(x == 42))); - Not supported in clang
+  // __attribute__((assume(x == 42))); // NON_COMPLIANT[FALSE_NEGATIVE] - Not supported in clang
 
   switch (x) {
   case 1:
@@ -269,43 +277,41 @@ void gf35() {
   }
 }
 
-// Not supported in clang.
-// int gf36 (uid_t);
-
-// int
-// gf36 (int x)
-// {
-//   return x == 0;
-// }
-
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Dollar-Signs.html#Dollar-Signs
 void gf37() {
-  int a$1; // NON_COMPLIANT
+  int a$1; // NON_COMPLIANT[FALSE_NEGATIVE]
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Character-Escapes.html#Character-Escapes
 void gf38() {
-  const char *c = "test\e"; // NON_COMPLIANT
+  const char *c = "test\e"; // NON_COMPLIANT[FALSE_NEGATIVE]
 }
 
 struct gf39s {
   int x;
   char y;
 } gf39v;
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Alignment.html#Alignment
 void gf39() {
   __alignof__(gf39v.x); // NON_COMPLIANT
 }
 
-// enum gf40 {}; // not supported in clang
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Incomplete-Enums.html#Incomplete-Enums
+// enum gf40 {}; // NON_COMPLIANT[FALSE_NEGATIVE] - not supported in clang
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Function-Names.html#Function-Names
 void gf41() {
-  printf("__FUNCTION__ = %s\n", __FUNCTION__);               // NON_COMPLIANT
-  printf("__PRETTY_FUNCTION__ = %s\n", __PRETTY_FUNCTION__); // NON_COMPLIANT
+  printf("__FUNCTION__ = %s\n", __FUNCTION__);               // NON_COMPLIANT[FALSE_NEGATIVE]
+  printf("__PRETTY_FUNCTION__ = %s\n", __PRETTY_FUNCTION__); // NON_COMPLIANT[FALSE_NEGATIVE]
 }
 
+// Reference: https://clang.llvm.org/docs/LanguageExtensions.html#builtin-macros
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html#Other-Builtins
 void gf42() {
-  __builtin_extract_return_addr(0);
-  __builtin_frob_return_addr(0);
-  __builtin_frame_address(0);
+  __builtin_extract_return_addr(0); // NON_COMPLIANT
+  __builtin_frob_return_addr(0); // NON_COMPLIANT
+  __builtin_frame_address(0); // NON_COMPLIANT
 }
 
 struct gf43s {
@@ -322,6 +328,7 @@ struct gf44s {
   char y;
 } gf44v;
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/_005f_005fsync-Builtins.html#g_t_005f_005fsync-Builtins
 void gf44() {
   int i;
   __sync_fetch_and_add(&i, 0);  // NON_COMPLIANT
@@ -343,12 +350,15 @@ void gf44() {
   __sync_lock_release(&i, 0);
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Binary-constants.html#Binary-constants
 void gf45() {
-  int i = 0b101010; // NON_COMPLIANT
+  int i = 0b101010; // NON_COMPLIANT[FALSE_NEGATIVE]
 }
 
-__thread int gf46; // NON_COMPLIANT
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Thread-Local.html#Thread-Local
+__thread int gf46; // NON_COMPLIANT[FALSE_NEGATIVE]
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Unnamed-Fields.html#Unnamed-Fields
 void gf47() { // NON_COMPLIANT in versions < C11.
   struct {
     int a;
@@ -360,6 +370,7 @@ void gf47() { // NON_COMPLIANT in versions < C11.
   } f;
 }
 
+// Reference: https://gcc.gnu.org/onlinedocs/gcc/Other-Builtins.html#Other-Builtins
 void gf48(){
     __builtin_alloca(0); // NON_COMPLIANT (all __builtin functions are non-compliant.)
 }