Fix RULE-9-4 bug, update test and metadata

Author: Nikita Kraiouchkine

c/misra/src/rules/RULE-9-4/RepeatedInitializationOfAggregateObjectElement.ql

@@ -43,6 +43,8 @@ string getNestedArrayIndexString(Expr e) {
           |
             elementIndex
           ).toString() + "]"
+      order by
+        depth desc
     )
 }
 
@@ -95,8 +97,7 @@ predicate hasMultipleInitializerExprsForSameIndex(ArrayAggregateLiteral root, Ex
  * that initialize the same Field and are part of the same `ClassAggregateLiteral`.
  * This predicate is therefore unable to distinguish the individual duplicate expressions.
  */
-predicate hasMultipleInitializerExprsForSameField(ClassAggregateLiteral root, Expr expr, Field f) {
-  expr = root.getFieldExpr(f) and
+predicate hasMultipleInitializerExprsForSameField(ClassAggregateLiteral root, Field f) {
   count(root.getFieldExpr(f)) > 1
 }
 
@@ -116,7 +117,7 @@ where
       // we cannot distinguish between different aggregate field init expressions.
       // therefore, we only report the root aggregate rather than any child init expr.
       // see `hasMultipleInitializerExprsForSameField` documentation.
-      hasMultipleInitializerExprsForSameField(root, _, f) and
+      hasMultipleInitializerExprsForSameField(root, f) and
       e1 = root and
       e2 = root and
       elementDescription = f.getQualifiedName() and

c/misra/test/rules/RULE-9-4/RepeatedInitializationOfAggregateObjectElement.expected

@@ -1,4 +1,4 @@
 | test.c:10:16:10:16 | 1 | $@ repeats initialization of element [0], which is already initialized $@. | test.c:9:14:10:26 | {...} | Array aggregate literal | test.c:10:7:10:7 | 0 | here |
 | test.c:12:28:12:28 | 1 | $@ repeats initialization of element [0][0], which is already initialized $@. | test.c:12:17:16:29 | {...} | Array aggregate literal | test.c:16:28:16:28 | 1 | here |
-| test.c:24:34:24:34 | 1 | $@ repeats initialization of element [0][0][0], which is already initialized $@. | test.c:24:20:26:35 | {...} | Array aggregate literal | test.c:26:34:26:34 | 1 | here |
+| test.c:25:64:25:64 | 7 | $@ repeats initialization of element [1][1][0], which is already initialized $@. | test.c:24:20:26:35 | {...} | Array aggregate literal | test.c:26:34:26:34 | 1 | here |
 | test.c:36:17:37:25 | {...} | $@ repeats initialization of element s1::a. | test.c:36:17:37:25 | {...} | Structure aggregate literal | test.c:36:17:37:25 | {...} | here |

c/misra/test/rules/RULE-9-4/test.c

@@ -23,7 +23,7 @@ void test_arrays(void) {
 
   int a7[2][2][2] = {[0][0][0] = 1, [0][0][1] = 2, [0][1][0] = 3, [0][1][1] = 4,
                      [1][0][0] = 5, [1][0][1] = 6, [1][1][0] = 7, [1][1][1] = 8,
-                     [0][0][0] = 1}; // NON_COMPLIANT
+                     [1][1][0] = 1}; // NON_COMPLIANT
                                      // - repeated
                                      // initialiation
                                      // of [0][0][0]

rule_packages/c/Memory1.json

@@ -10,7 +10,7 @@
           "kind": "problem",
           "name": "The initializer for an aggregate or union shall be enclosed in braces",
           "precision": "high",
-          "severity": "warning",
+          "severity": "recommendation",
           "short_name": "InitializerForAggregateOrUnionNotEnclosedInBraces",
           "shared_implementation_short_name": "UseInitializerBracesToMatchAggregateTypeStructure",
           "tags": [