IdentifierHidden: move type exclusion to rule not userdecl type, and omit intentional overloads

Author: knewbury01

cpp/common/src/codingstandards/cpp/Scope.qll

@@ -71,7 +71,6 @@ class UserDeclaration extends Declaration {
     not this instanceof ClassTemplateInstantiation and
     // compiler inferred parameters have name of p#0
     not this.(Parameter).getName() = "p#0"
-    and not this instanceof Type
   }
 }
 
@@ -275,6 +274,8 @@ predicate hides(UserDeclaration v1, UserDeclaration v2) {
     hides_candidate(v1, mid) and
     hides_candidate(mid, v2)
   )
+  //ignore intentional overloads
+  and not v1.(Function).getAnOverload() = v2
 }
 
 /** Holds if `v2` strictly (`v2` is in an inner scope compared to `v1`) hides `v1`. */

cpp/common/src/codingstandards/cpp/rules/identifierhidden/IdentifierHidden.qll

@@ -17,6 +17,9 @@ query predicate problems(UserDeclaration v2, string message, UserDeclaration v1,
   //ignore template variables for this rule
   not v1 instanceof TemplateVariable and
   not v2 instanceof TemplateVariable and
+  //ignore types for this rule
+  not v2 instanceof Type and
+  not v1 instanceof Type and
   hidesStrict(v1, v2) and
   not excludedViaNestedNamespaces(v2, v1) and
   varName = v1.getName() and