Comvert ARR37-C to use the new dataflow library

Author: jketema

c/cert/src/rules/ARR37-C/DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql

@@ -18,7 +18,7 @@
 
 import cpp
 import codingstandards.c.cert
-import semmle.code.cpp.dataflow.DataFlow
+import semmle.code.cpp.dataflow.new.DataFlow
 import NonArrayPointerToArrayIndexingExprFlow::PathGraph
 
 /**

c/cert/test/rules/ARR37-C/DoNotUsePointerArithmeticOnNonArrayObjectPointers.expected

@@ -1,22 +1,21 @@
-WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql:28,60-68)
-WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql:29,22-30)
-WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql:41,20-28)
-WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql:49,26-34)
-WARNING: module 'DataFlow' has been deprecated and may be removed in future (DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql:70,3-11)
 edges
-| test.c:14:38:14:39 | p1 | test.c:18:10:18:11 | v1 | provenance |  |
-| test.c:14:38:14:39 | p1 | test.c:19:10:19:11 | v2 | provenance |  |
+| test.c:14:38:14:39 | p1 | test.c:16:13:16:14 | p1 | provenance |  |
+| test.c:14:38:14:39 | p1 | test.c:17:13:17:14 | p1 | provenance |  |
 | test.c:14:38:14:39 | p1 | test.c:20:10:20:11 | p1 | provenance |  |
 | test.c:14:38:14:39 | p1 | test.c:21:10:21:11 | p1 | provenance |  |
 | test.c:14:38:14:39 | p1 | test.c:22:9:22:10 | p1 | provenance |  |
 | test.c:14:38:14:39 | p1 | test.c:23:13:23:14 | p1 | provenance |  |
 | test.c:14:38:14:39 | p1 | test.c:24:9:24:10 | p1 | provenance |  |
 | test.c:14:38:14:39 | p1 | test.c:25:9:25:10 | p1 | provenance |  |
+| test.c:16:13:16:14 | p1 | test.c:18:10:18:13 | ... ++ | provenance |  |
+| test.c:17:13:17:14 | p1 | test.c:19:10:19:13 | ... -- | provenance |  |
 | test.c:51:30:51:38 | & ... | test.c:14:38:14:39 | p1 | provenance |  |
 nodes
 | test.c:14:38:14:39 | p1 | semmle.label | p1 |
-| test.c:18:10:18:11 | v1 | semmle.label | v1 |
-| test.c:19:10:19:11 | v2 | semmle.label | v2 |
+| test.c:16:13:16:14 | p1 | semmle.label | p1 |
+| test.c:17:13:17:14 | p1 | semmle.label | p1 |
+| test.c:18:10:18:13 | ... ++ | semmle.label | ... ++ |
+| test.c:19:10:19:13 | ... -- | semmle.label | ... -- |
 | test.c:20:10:20:11 | p1 | semmle.label | p1 |
 | test.c:21:10:21:11 | p1 | semmle.label | p1 |
 | test.c:22:9:22:10 | p1 | semmle.label | p1 |
@@ -32,8 +31,8 @@ nodes
 | test.c:51:30:51:38 | & ... | semmle.label | & ... |
 subpaths
 #select
-| test.c:18:10:18:11 | v1 | test.c:51:30:51:38 | & ... | test.c:18:10:18:11 | v1 | Pointer arithmetic on non-array object pointer. |
-| test.c:19:10:19:11 | v2 | test.c:51:30:51:38 | & ... | test.c:19:10:19:11 | v2 | Pointer arithmetic on non-array object pointer. |
+| test.c:18:10:18:13 | ... ++ | test.c:51:30:51:38 | & ... | test.c:18:10:18:13 | ... ++ | Pointer arithmetic on non-array object pointer. |
+| test.c:19:10:19:13 | ... -- | test.c:51:30:51:38 | & ... | test.c:19:10:19:13 | ... -- | Pointer arithmetic on non-array object pointer. |
 | test.c:20:10:20:11 | p1 | test.c:51:30:51:38 | & ... | test.c:20:10:20:11 | p1 | Pointer arithmetic on non-array object pointer. |
 | test.c:21:10:21:11 | p1 | test.c:51:30:51:38 | & ... | test.c:21:10:21:11 | p1 | Pointer arithmetic on non-array object pointer. |
 | test.c:22:9:22:10 | p1 | test.c:51:30:51:38 | & ... | test.c:22:9:22:10 | p1 | Pointer arithmetic on non-array object pointer. |