Rule 17.2: Simplify alert message.

Author: lcartey

c/misra/src/rules/RULE-17-2/RecursiveFunctionCondition.ql

@@ -20,6 +20,6 @@ where
   fc.getEnclosingFunction() = f and
   fc.getTarget().calls*(f) and
   if fc.getTarget() = f
-  then msg = "This call directly invokes its containing function $@."
-  else msg = "The function " + f + " is indirectly recursive via this call to $@."
+  then msg = f + " calls itself directly."
+  else msg = f + " is indirectly recursive via this call to $@."
 select fc, msg, fc.getTarget(), fc.getTarget().getName()

c/misra/test/rules/RULE-17-2/RecursiveFunctionCondition.expected

@@ -1,3 +1,3 @@
-| test.c:8:3:8:4 | call to f3 | This call directly invokes its containing function $@. | test.c:7:6:7:7 | f3 | f3 |
-| test.c:15:3:15:4 | call to f2 | The function f5 is indirectly recursive via this call to $@. | test.c:17:6:17:7 | f2 | f2 |
-| test.c:18:3:18:4 | call to f5 | The function f2 is indirectly recursive via this call to $@. | test.c:14:6:14:7 | f5 | f5 |
+| test.c:8:3:8:4 | call to f3 | f3 calls itself directly. | test.c:7:6:7:7 | f3 | f3 |
+| test.c:15:3:15:4 | call to f2 | f5 is indirectly recursive via this call to $@. | test.c:17:6:17:7 | f2 | f2 |
+| test.c:18:3:18:4 | call to f5 | f2 is indirectly recursive via this call to $@. | test.c:14:6:14:7 | f5 | f5 |