clean up namespace, distinguish between lambda param and function params

Author: jeongsoolee09

cpp/common/src/codingstandards/cpp/rules/unusedparameter/UnusedParameter.qll

@@ -11,32 +11,30 @@ abstract class UnusedParameterSharedQuery extends Query { }
 
 Query getQuery() { result instanceof UnusedParameterSharedQuery }
 
-query predicate isMaybeUnusedParameter(Parameter parameter) {
+predicate isMaybeUnusedParameter(Parameter parameter) {
   parameter.getAnAttribute().toString() = "maybe_unused"
 }
 
 predicate isLambdaParameter(Parameter parameter) {
   exists(LambdaExpression lambda | lambda.getLambdaFunction().getParameter(_) = parameter)
 }
 
-predicate isLambdaMaybeUnusedParameter(Parameter parameter) {
-  exists(LambdaExpression lambda | lambda.getLambdaFunction().getParameter(_) = parameter) and
-  isMaybeUnusedParameter(parameter)
-}
-
-query predicate lambdaExprParamHasAccess(Parameter parameter) {
-  exists(VariableAccess va | isLambdaParameter(parameter) and parameter.getAnAccess() = va)
-}
-
 query predicate problems(UnusedParameter p, string message, Function f, string fName) {
   not isExcluded(p, getQuery()) and
-  (
+  if isLambdaParameter(p)
+  then (
+    not isMaybeUnusedParameter(p) and
+    f = p.getFunction() and
+    // Virtual functions are covered by a different rule
+    not f.isVirtual() and
+    message = "Unused parameter '" + p.getName() + "' for function $@." and
+    fName = "lambda expression"
+  ) else (
     not isMaybeUnusedParameter(p) and
     f = p.getFunction() and
     // Virtual functions are covered by a different rule
-    not f.isVirtual()
-  ) and
-  message = "Unused parameter '" + p.getName() + "' for function $@." and
-  // fName = f.getQualifiedName()
-  fName = "TODO."
+    not f.isVirtual() and
+    message = "Unused parameter '" + p.getName() + "' for function $@." and
+    fName = f.getQualifiedName()
+  )
 }