Use path.extname for some extension checks

Author: mbg

lib/analyze-action-post.js

@@ -334,7 +334,7 @@ test("resolveQuerySuiteAlias", (t) => {
   for (const suite of defaultSuites) {
     const resolved = resolveQuerySuiteAlias(KnownLanguage.go, suite);
     t.assert(
-      resolved.endsWith(".qls"),
+      path.extname(resolved) === ".qls",
       "Resolved default suite doesn't end in .qls",
     );
     t.assert(

lib/analyze-action.js

@@ -59,7 +59,7 @@ export async function uploadCombinedSarifArtifacts(
         for (const outputDir of outputDirs) {
           const sarifFiles = fs
             .readdirSync(path.resolve(baseTempDir, outputDir))
-            .filter((f) => f.endsWith(".sarif"));
+            .filter((f) => path.extname(f) === ".sarif");
 
           for (const sarifFile of sarifFiles) {
             toUpload.push(path.resolve(baseTempDir, outputDir, sarifFile));

lib/init-action-post.js

@@ -480,8 +480,9 @@ export async function getGroupedSarifFilePaths(
   const results = {};
 
   if (stats.isDirectory()) {
-    let sarifFiles = findSarifFilesInDir(sarifPath, (name) =>
-      name.endsWith(".sarif"),
+    let sarifFiles = findSarifFilesInDir(
+      sarifPath,
+      (name) => path.extname(name) === ".sarif",
     );
     logger.debug(
       `Found the following .sarif files in ${sarifPath}: ${sarifFiles.join(", ")}`,