Skip to content

Commit 6f964b7

Browse files
committed
Cover more cases in upload-sarif check
1 parent 6bdf5d3 commit 6f964b7

File tree

2 files changed

+82
-0
lines changed

2 files changed

+82
-0
lines changed

.github/workflows/__upload-sarif.yml

Lines changed: 42 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

pr-checks/checks/upload-sarif.yml

Lines changed: 40 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@ steps:
1717
ref: 'refs/heads/main'
1818
sha: '5e235361806c361d4d3f8859e3c897658025a9a2'
1919
upload: never
20+
output: ${{ runner.temp }}/results
2021

2122
- name: |
2223
Upload all SARIF files for `analysis-kinds: ${{ matrix.analysis-kinds }}`
@@ -25,9 +26,48 @@ steps:
2526
with:
2627
ref: 'refs/heads/main'
2728
sha: '5e235361806c361d4d3f8859e3c897658025a9a2'
29+
sarif_file: ${{ runner.temp }}/results
2830
- name: "Check output from `upload-sarif` step for `code-scanning`"
2931
if: "contains(matrix.analysis-kinds, 'code-scanning') && !(fromJSON(steps.upload-sarif.outputs.sarif-ids).code-scanning)"
3032
run: exit 1
3133
- name: "Check output from `upload-sarif` step for `code-quality`"
3234
if: "contains(matrix.analysis-kinds, 'code-quality') && !(fromJSON(steps.upload-sarif.outputs.sarif-ids).code-quality)"
3335
run: exit 1
36+
37+
- name: Upload single SARIF file for Code Scanning
38+
uses: ./../action/upload-sarif
39+
id: upload-single-sarif-code-scanning
40+
if: "contains(matrix.analysis-kinds, 'code-scanning')"
41+
with:
42+
ref: 'refs/heads/main'
43+
sha: '5e235361806c361d4d3f8859e3c897658025a9a2'
44+
sarif_file: ${{ runner.temp }}/results/javascript.sarif
45+
- name: "Check output from `upload-single-sarif-code-scanning` step"
46+
if: "contains(matrix.analysis-kinds, 'code-scanning') && !(fromJSON(steps.upload-single-sarif-code-scanning.outputs.sarif-ids).code-scanning)"
47+
run: exit 1
48+
- name: Upload single SARIF file for Code Scanning
49+
uses: ./../action/upload-sarif
50+
id: upload-single-sarif-code-quality
51+
if: "contains(matrix.analysis-kinds, 'code-quality')"
52+
with:
53+
ref: 'refs/heads/main'
54+
sha: '5e235361806c361d4d3f8859e3c897658025a9a2'
55+
sarif_file: ${{ runner.temp }}/results/javascript.quality.sarif
56+
- name: "Check output from `upload-single-sarif-code-quality` step"
57+
if: "contains(matrix.analysis-kinds, 'code-quality') && !(fromJSON(steps.upload-single-sarif-code-quality.outputs.sarif-ids).code-quality)"
58+
run: exit 1
59+
60+
- name: Change SARIF file extension
61+
if: "contains(matrix.analysis-kinds, 'code-scanning')"
62+
run: mv ${{ runner.temp }}/results/javascript.sarif ${{ runner.temp }}/results/javascript.sarif.json
63+
- name: Upload single non-`.sarif` file
64+
uses: ./../action/upload-sarif
65+
id: upload-single-non-sarif
66+
if: "contains(matrix.analysis-kinds, 'code-scanning')"
67+
with:
68+
ref: 'refs/heads/main'
69+
sha: '5e235361806c361d4d3f8859e3c897658025a9a2'
70+
sarif_file: ${{ runner.temp }}/results/javascript.sarif.json
71+
- name: "Check output from `upload-single-non-sarif` step"
72+
if: "contains(matrix.analysis-kinds, 'code-scanning') && !(fromJSON(steps.upload-single-non-sarif.outputs.sarif-ids).code-scanning)"
73+
run: exit 1

0 commit comments

Comments
 (0)