move the logging and setFailed logic into the deploymentConfirmation function

Author: GrantBirki

__tests__/functions/deployment-confirmation.test.js

@@ -13,6 +13,7 @@ beforeEach(() => {
   jest.spyOn(core, 'info').mockImplementation(() => {})
   jest.spyOn(core, 'debug').mockImplementation(() => {})
   jest.spyOn(core, 'warning').mockImplementation(() => {})
+  jest.spyOn(core, 'setFailed').mockImplementation(() => {})
 
   // Mock setTimeout to execute immediately
   jest.spyOn(global, 'setTimeout').mockImplementation(fn => fn())
@@ -118,6 +119,9 @@ test('successfully prompts for deployment confirmation and gets confirmed by the
   expect(core.info).toHaveBeenCalledWith(
     `🕒 waiting ${COLORS.highlight}60${COLORS.reset} seconds for deployment confirmation`
   )
+  expect(core.info).toHaveBeenCalledWith(
+    `✅ deployment confirmed by ${COLORS.highlight}monalisa${COLORS.reset} - sha: ${COLORS.highlight}abc123${COLORS.reset}`
+  )
 
   expect(octokit.rest.reactions.listForIssueComment).toHaveBeenCalledWith({
     comment_id: 124,
@@ -159,6 +163,10 @@ test('user rejects the deployment with thumbs down', async () => {
     repo: 'test',
     headers: API_HEADERS
   })
+
+  expect(core.setFailed).toHaveBeenCalledWith(
+    `❌ deployment rejected by ${COLORS.highlight}monalisa${COLORS.reset}`
+  )
 })
 
 test('deployment confirmation times out after no response', async () => {
@@ -185,7 +193,7 @@ test('deployment confirmation times out after no response', async () => {
     headers: API_HEADERS
   })
 
-  expect(core.info).toHaveBeenCalledWith(
+  expect(core.setFailed).toHaveBeenCalledWith(
     `⏱️ deployment confirmation timed out after ${COLORS.highlight}60${COLORS.reset} seconds`
   )
 })
@@ -229,6 +237,9 @@ test('ignores reactions from other users', async () => {
   expect(core.debug).toHaveBeenCalledWith(
     'ignoring reaction from other-user, expected monalisa'
   )
+  expect(core.info).toHaveBeenCalledWith(
+    `✅ deployment confirmed by ${COLORS.highlight}monalisa${COLORS.reset} - sha: ${COLORS.highlight}abc123${COLORS.reset}`
+  )
 })
 
 test('handles API errors gracefully', async () => {
@@ -254,4 +265,7 @@ test('handles API errors gracefully', async () => {
     'temporary failure when checking for reactions on the deployment confirmation comment: API error'
   )
   expect(octokit.rest.reactions.listForIssueComment).toHaveBeenCalledTimes(2)
+  expect(core.info).toHaveBeenCalledWith(
+    `✅ deployment confirmed by ${COLORS.highlight}monalisa${COLORS.reset} - sha: ${COLORS.highlight}abc123${COLORS.reset}`
+  )
 })

dist/index.js

@@ -106,6 +106,10 @@ export async function deploymentConfirmation(context, octokit, data) {
               headers: API_HEADERS
             })
 
+            core.info(
+              `✅ deployment confirmed by ${COLORS.highlight}${context.actor}${COLORS.reset} - sha: ${COLORS.highlight}${data.sha}${COLORS.reset}`
+            )
+
             return true
           } else if (reaction.content === thumbsDown) {
             // Update confirmation comment with cancellation message
@@ -116,6 +120,10 @@ export async function deploymentConfirmation(context, octokit, data) {
               headers: API_HEADERS
             })
 
+            core.setFailed(
+              `❌ deployment rejected by ${COLORS.highlight}${context.actor}${COLORS.reset}`
+            )
+
             return false
           }
         } else {
@@ -143,7 +151,7 @@ export async function deploymentConfirmation(context, octokit, data) {
     headers: API_HEADERS
   })
 
-  core.info(
+  core.setFailed(
     `⏱️ deployment confirmation timed out after ${COLORS.highlight}${data.deployment_confirmation_timeout}${COLORS.reset} seconds`
   )
   return false

dist/index.js.map

@@ -608,7 +608,7 @@ export async function run() {
     const log_url = `${process.env.GITHUB_SERVER_URL}/${context.repo.owner}/${context.repo.repo}/actions/runs/${github_run_id}`
 
     // if the deployment_confirmation is set to 'true', then we will prompt the user to confirm the deployment
-    if (inputs.deployment_confirmation) {
+    if (inputs.deployment_confirmation === true) {
       const deploymentConfirmed = await deploymentConfirmation(
         context,
         octokit,
@@ -631,13 +631,13 @@ export async function run() {
         }
       )
       if (deploymentConfirmed === true) {
-        core.info(
-          `✅ deployment confirmed by ${COLORS.highlight}${context.actor}${COLORS.reset} - sha: ${COLORS.highlight}${precheckResults.sha}${COLORS.reset}`
+        core.debug(
+          `deploymentConfirmation() was successful - continuing with the deployment`
         )
       } else {
         // Set the bypass state to true so that the post run logic will not run
         core.saveState('bypass', 'true')
-        core.setFailed(`❌ deployment not confirmed - exiting`)
+        core.debug(`❌ deployment not confirmed - exiting`)
         return 'failure'
       }
     }