Skip to content

Commit b5ddb89

Browse files
committed
chore(scale-runners): log failures with same key name as variable name
Copilot pointed out correctly that it could be confusing to log `failedInstanceCount` using the key `missingInstanceCount` when there is a variable with that name.
1 parent cb5ce97 commit b5ddb89

File tree

1 file changed

+1
-1
lines changed
  • lambdas/functions/control-plane/src/scale-runners

1 file changed

+1
-1
lines changed

lambdas/functions/control-plane/src/scale-runners/scale-up.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -444,7 +444,7 @@ export async function scaleUp(payloads: ActionRequestMessageSQS[]): Promise<stri
444444
logger.warn('Some runners failed to be created, rejecting some messages so the requests are retried', {
445445
wanted: newRunners,
446446
got: instances.length,
447-
missingInstanceCount: failedInstanceCount,
447+
failedInstanceCount,
448448
});
449449

450450
invalidMessages.push(...messages.slice(0, failedInstanceCount).map(({ messageId }) => messageId));

0 commit comments

Comments
 (0)