You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Using GGG: use a unordered list for GGG-specific PR guidance
In a subsequent commit we want to mention that it is prefered to use an
empty desccription for a single commit PR, since the description is
copied as an in-patch commentary and having the same text twice (once in
the commit messge and once in the in-patch commentary) decreases
the signal-to-noise ratio for reviewers.
Before doing so, let's convert part of the first paragraph of the "How
can you use GitGitGadget?" section into an unorderded list. This will
make the text clearer when we mention single commit PRs later.
Copy file name to clipboardExpand all lines: index.html
+7-4Lines changed: 7 additions & 4 deletions
Original file line number
Diff line number
Diff line change
@@ -100,10 +100,13 @@ <h2>How can you use GitGitGadget?</h2>
100
100
So you cloned <ahref="https://github.com/git/git">https://github.com/git/git</a> and implemented a bug fix or a new feature?
101
101
And you already pushed it to your own fork?
102
102
Good, now is the time to direct your web browser to <ahref="https://github.com/gitgitgadget/git">https://github.com/gitgitgadget/git</a> (or to <ahref="https://github.com/git/git">https://github.com/git/git</a> ) and to open a Pull Request.
103
-
Please make sure to use a descriptive Pull Request title and description; GitGitGadget will use these as the subject and body of the cover letter (check out the <ahref="https://git-scm.com/docs/MyFirstContribution">MyFirstContribution</a> tutorial if you are not familiar with this terminology).
104
-
You can CC potential reviewers by adding a footer to the PR description with the following syntax:
A few things to note about a GitGitGadget Pull Request:
104
+
<ul>
105
+
<li>Please make sure to use a descriptive title and description; GitGitGadget will use these as the subject and body of the cover letter (check out the <ahref="https://git-scm.com/docs/MyFirstContribution">MyFirstContribution</a> tutorial if you are not familiar with this terminology).</li>
106
+
<li>You can CC potential reviewers by adding a footer to the PR description with the following syntax:</br>
You will also want to read <ahref="https://git-scm.com/docs/SubmittingPatches">Git's contribution guidelines</a> to make sure that your contributions are in the expected form, as well as the project's <ahref="https://github.com/git/git/blob/master/Documentation/CodingGuidelines">coding guidelines</a>.
109
112
You might also want to read the <ahref="https://git-scm.com/docs/gitworkflows">gitworkflows</a> manual page to understand how your contributions will be integrated in Git's repository, as well as <ahref="https://github.com/git/git/blob/todo/MaintNotes">this note from Git's maintainer</a>.
0 commit comments