Merge branch 'sg/upload-pack-error-message-fix'

gitster · gitster · commit e58a4de3bb28 · 2024-03-05T09:44:43.000-08:00
An error message from "git upload-pack", which responds to "git
fetch" requests, had a trialing NUL in it, which has been
corrected.

* sg/upload-pack-error-message-fix:
  upload-pack: don't send null character in abort message to the client
diff --git a/upload-pack.c b/upload-pack.c
@@ -463,7 +463,7 @@ static void create_pack_file(struct upload_pack_data *pack_data,
 
  fail:
 	free(output_state);
-	send_client_data(3, abort_msg, sizeof(abort_msg),
+	send_client_data(3, abort_msg, strlen(abort_msg),
 			 pack_data->use_sideband);
 	die("git upload-pack: %s", abort_msg);
 }

Original file line number	Diff line number	Diff line change
`@@ -463,7 +463,7 @@ static void create_pack_file(struct upload_pack_data *pack_data,`
`463`	`463`
`464`	`464`	`fail:`
`465`	`465`	`free(output_state);`
`466`		`- send_client_data(3, abort_msg, sizeof(abort_msg),`
	`466`	`+ send_client_data(3, abort_msg, strlen(abort_msg),`
`467`	`467`	`pack_data->use_sideband);`
`468`	`468`	`die("git upload-pack: %s", abort_msg);`
`469`	`469`	`}`