reftable: fix calls to free(3P)

pks-t · gitster · commit daa59e9c439c · 2024-10-02T07:53:56.000-07:00
There are a small set of calls to free(3P) in the reftable library. As
the reftable allocators are pluggable we should rather call the reftable
specific function, which is `reftable_free()`.

Convert the code accordingly.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/reftable/stack.c b/reftable/stack.c
@@ -1421,7 +1421,7 @@ static int stack_compact_range(struct reftable_stack *st,
 		struct lock_file *table_lock = &table_locks[i];
 		char *table_path = get_locked_file_path(table_lock);
 		unlink(table_path);
-		free(table_path);
+		reftable_free(table_path);
 	}
 
 done:
diff --git a/t/unit-tests/t-reftable-readwrite.c b/t/unit-tests/t-reftable-readwrite.c
@@ -76,8 +76,8 @@ static void write_table(char ***names, struct strbuf *buf, int N,
 
 	t_reftable_write_to_buf(buf, refs, N, logs, N, &opts);
 
-	free(refs);
-	free(logs);
+	reftable_free(refs);
+	reftable_free(logs);
 }
 
 static void t_log_buffer_size(void)

Original file line number	Diff line number	Diff line change
`@@ -1421,7 +1421,7 @@ static int stack_compact_range(struct reftable_stack *st,`
`1421`	`1421`	`struct lock_file *table_lock = &table_locks[i];`
`1422`	`1422`	`char *table_path = get_locked_file_path(table_lock);`
`1423`	`1423`	`unlink(table_path);`
`1424`		`- free(table_path);`
	`1424`	`+ reftable_free(table_path);`
`1425`	`1425`	`}`
`1426`	`1426`
`1427`	`1427`	`done:`
Original file line number	Diff line number	Diff line change
`@@ -76,8 +76,8 @@ static void write_table(char **names, struct strbuf buf, int N,`
`76`	`76`
`77`	`77`	`t_reftable_write_to_buf(buf, refs, N, logs, N, &opts);`
`78`	`78`
`79`		`- free(refs);`
`80`		`- free(logs);`
	`79`	`+ reftable_free(refs);`
	`80`	`+ reftable_free(logs);`
`81`	`81`	`}`
`82`	`82`
`83`	`83`	`static void t_log_buffer_size(void)`