builtin/repack: fix leaking keep-pack list

pks-t · gitster · commit 46f6ca2a68e0 · 2024-09-05T08:49:13.000-07:00
The list of packs to keep is populated via a command line option but
never free'd. Plug this memory leak.

Signed-off-by: Patrick Steinhardt &lt;ps@pks.im&gt;
Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/builtin/repack.c b/builtin/repack.c
@@ -1525,6 +1525,7 @@ int cmd_repack(int argc, const char **argv, const char *prefix)
 	}
 
 cleanup:
+	string_list_clear(&keep_pack_list, 0);
 	string_list_clear(&names, 1);
 	existing_packs_release(&existing);
 	free_pack_geometry(&geometry);
diff --git a/t/t6500-gc.sh b/t/t6500-gc.sh
@@ -3,6 +3,7 @@
 test_description='basic git gc tests
 '
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 . "$TEST_DIRECTORY"/lib-terminal.sh
 
diff --git a/t/t7703-repack-geometric.sh b/t/t7703-repack-geometric.sh
@@ -2,6 +2,7 @@
 
 test_description='git repack --geometric works correctly'
 
+TEST_PASSES_SANITIZE_LEAK=true
 . ./test-lib.sh
 
 GIT_TEST_MULTI_PACK_INDEX=0

Original file line number	Diff line number	Diff line change
`@@ -1525,6 +1525,7 @@ int cmd_repack(int argc, const char *argv, const char prefix)`
`1525`	`1525`	`}`
`1526`	`1526`
`1527`	`1527`	`cleanup:`
	`1528`	`+ string_list_clear(&keep_pack_list, 0);`
`1528`	`1529`	`string_list_clear(&names, 1);`
`1529`	`1530`	`existing_packs_release(&existing);`
`1530`	`1531`	`free_pack_geometry(&geometry);`
Original file line number	Diff line number	Diff line change
`@@ -3,6 +3,7 @@`
`3`	`3`	`test_description='basic git gc tests`
`4`	`4`	`'`
`5`	`5`
	`6`	`+TEST_PASSES_SANITIZE_LEAK=true`
`6`	`7`	`. ./test-lib.sh`
`7`	`8`	`. "$TEST_DIRECTORY"/lib-terminal.sh`
`8`	`9`