Skip to content

Commit 383e5e1

Browse files
benknoblegitster
authored andcommitted
parseopt: restore const qualifier to parsed filename
This was unintentionally dropped in ccfcaf3 (parseopt: values of pathname type can be prefixed with :(optional), 2025-09-28). Notably, continue dropping the const qualifier when free'ing value; see 4049b9c (fix const issues with some functions, 2007-10-16) or 83838d5 (cast variable in call to free() in builtin/diff.c and submodule.c, 2011-11-06) for more details on why. Suggested-by: Phillip Wood <phillip.wood@dunelm.org.uk> Signed-off-by: D. Ben Knoble <ben.knoble+github@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent 4dbb7f4 commit 383e5e1

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

parse-options.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ static enum parse_opt_result do_get_value(struct parse_opt_ctx_t *p,
213213
if (unset)
214214
value = NULL;
215215
else if (opt->flags & PARSE_OPT_OPTARG && !p->opt)
216-
value = (char *)opt->defval;
216+
value = (const char *)opt->defval;
217217
else {
218218
int err = get_arg(p, opt, flags, &value);
219219
if (err)

0 commit comments

Comments
 (0)