test_i18ngrep: hard deprecate and forbid its use

gitster · gitster · commit 381a83dfa3aa · 2024-03-02T10:21:10.000-08:00
Since v2.44.0-rc0~109 (Merge branch 'sp/test-i18ngrep', 2023-12-27)
none of the tests we have, either in 'master' or in flight and
collected in 'seen', use test_i18ngrep.

Perhaps it is good time to update test_i18ngrep to BUG to avoid
people adding new calls to it.

Signed-off-by: Junio C Hamano &lt;gitster@pobox.com&gt;
diff --git a/t/test-lib-functions.sh b/t/test-lib-functions.sh
@@ -1263,9 +1263,8 @@ test_cmp_bin () {
 	cmp "$@"
 }
 
-# Deprecated - do not use this in new code
 test_i18ngrep () {
-	test_grep "$@"
+	BUG "do not use test_i18ngrep---use test_grep instead"
 }
 
 test_grep () {

Original file line number	Diff line number	Diff line change
`@@ -1263,9 +1263,8 @@ test_cmp_bin () {`
`1263`	`1263`	`cmp "$@"`
`1264`	`1264`	`}`
`1265`	`1265`
`1266`		`-# Deprecated - do not use this in new code`
`1267`	`1266`	`test_i18ngrep () {`
`1268`		`- test_grep "$@"`
	`1267`	`+ BUG "do not use test_i18ngrep---use test_grep instead"`
`1269`	`1268`	`}`
`1270`	`1269`
`1271`	`1270`	`test_grep () {`