Skip to content

Commit 040fc0b

Browse files
ezekielnewrengitster
authored andcommitted
xdiff: rename rindex -> reference_index
The classic diff adds only the lines that it's going to consider, during the diff, to an array. A mapping between the compacted array, and the lines of the file that they reference, are facilitated by this array. Signed-off-by: Ezekiel Newren <ezekielnewren@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
1 parent e789627 commit 040fc0b

File tree

3 files changed

+9
-9
lines changed

3 files changed

+9
-9
lines changed

xdiff/xdiffi.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424

2525
static size_t get_hash(xdfile_t *xdf, long index)
2626
{
27-
return xdf->recs[xdf->rindex[index]].minimal_perfect_hash;
27+
return xdf->recs[xdf->reference_index[index]].minimal_perfect_hash;
2828
}
2929

3030
#define XDL_MAX_COST_MIN 256
@@ -278,10 +278,10 @@ int xdl_recs_cmp(xdfile_t *xdf1, long off1, long lim1,
278278
*/
279279
if (off1 == lim1) {
280280
for (; off2 < lim2; off2++)
281-
xdf2->changed[xdf2->rindex[off2]] = true;
281+
xdf2->changed[xdf2->reference_index[off2]] = true;
282282
} else if (off2 == lim2) {
283283
for (; off1 < lim1; off1++)
284-
xdf1->changed[xdf1->rindex[off1]] = true;
284+
xdf1->changed[xdf1->reference_index[off1]] = true;
285285
} else {
286286
xdpsplit_t spl;
287287
spl.i1 = spl.i2 = 0;

xdiff/xprepare.c

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,7 @@ static int xdl_classify_record(unsigned int pass, xdlclassifier_t *cf, xrecord_t
128128

129129
static void xdl_free_ctx(xdfile_t *xdf)
130130
{
131-
xdl_free(xdf->rindex);
131+
xdl_free(xdf->reference_index);
132132
xdl_free(xdf->changed - 1);
133133
xdl_free(xdf->recs);
134134
}
@@ -141,7 +141,7 @@ static int xdl_prepare_ctx(unsigned int pass, mmfile_t *mf, long narec, xpparam_
141141
uint8_t const *blk, *cur, *top, *prev;
142142
xrecord_t *crec;
143143

144-
xdf->rindex = NULL;
144+
xdf->reference_index = NULL;
145145
xdf->changed = NULL;
146146
xdf->recs = NULL;
147147

@@ -169,7 +169,7 @@ static int xdl_prepare_ctx(unsigned int pass, mmfile_t *mf, long narec, xpparam_
169169

170170
if ((XDF_DIFF_ALG(xpp->flags) != XDF_PATIENCE_DIFF) &&
171171
(XDF_DIFF_ALG(xpp->flags) != XDF_HISTOGRAM_DIFF)) {
172-
if (!XDL_ALLOC_ARRAY(xdf->rindex, xdf->nrec + 1))
172+
if (!XDL_ALLOC_ARRAY(xdf->reference_index, xdf->nrec + 1))
173173
goto abort;
174174
}
175175

@@ -312,7 +312,7 @@ static int xdl_cleanup_records(xdlclassifier_t *cf, xdfile_t *xdf1, xdfile_t *xd
312312
i <= xdf1->dend; i++, recs++) {
313313
if (action1[i] == KEEP ||
314314
(action1[i] == INVESTIGATE && !xdl_clean_mmatch(action1, i, xdf1->dstart, xdf1->dend))) {
315-
xdf1->rindex[xdf1->nreff++] = i;
315+
xdf1->reference_index[xdf1->nreff++] = i;
316316
/* changed[i] remains false, i.e. keep */
317317
} else
318318
xdf1->changed[i] = true;
@@ -324,7 +324,7 @@ static int xdl_cleanup_records(xdlclassifier_t *cf, xdfile_t *xdf1, xdfile_t *xd
324324
i <= xdf2->dend; i++, recs++) {
325325
if (action2[i] == KEEP ||
326326
(action2[i] == INVESTIGATE && !xdl_clean_mmatch(action2, i, xdf2->dstart, xdf2->dend))) {
327-
xdf2->rindex[xdf2->nreff++] = i;
327+
xdf2->reference_index[xdf2->nreff++] = i;
328328
/* changed[i] remains false, i.e. keep */
329329
} else
330330
xdf2->changed[i] = true;

xdiff/xtypes.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ typedef struct s_xdfile {
4949
xrecord_t *recs;
5050
size_t nrec;
5151
bool *changed;
52-
size_t *rindex;
52+
size_t *reference_index;
5353
size_t nreff;
5454
ptrdiff_t dstart, dend;
5555
} xdfile_t;

0 commit comments

Comments
 (0)