Add setting to disable the show change submitted dialog (#85)

Author: ronaldme

src/GitExtensions.GerritPlugin/FormGerritPublish.cs

@@ -28,12 +28,16 @@ public partial class FormGerritPublish : FormGerritBase
         private string _currentBranchRemote;
         private readonly GerritCapabilities _capabilities;
         private readonly bool _shouldTargetLocalBranch;
+        private readonly bool _showChangeSubmittedDialog;
 
-        public FormGerritPublish(IGitUICommands uiCommand, GerritCapabilities capabilities, bool shouldTargetLocalBranch)
+        public FormGerritPublish(IGitUICommands uiCommand, GerritCapabilities capabilities,
+            bool shouldTargetLocalBranch, bool showChangeSubmittedDialog)
             : base(uiCommand)
         {
             _capabilities = capabilities;
             _shouldTargetLocalBranch = shouldTargetLocalBranch;
+            _showChangeSubmittedDialog = showChangeSubmittedDialog;
+
             InitializeComponent();
             Publish.Image = Images.Push.AdaptLightness();
             InitializeComplete();
@@ -104,7 +108,7 @@ private bool PublishChange(IWin32Window owner)
 
             if (!pushCommand.ErrorOccurred)
             {
-                if(GerritUtil.HadNewChange(pushCommand.CommandOutput, out var changeUri))
+                if (_showChangeSubmittedDialog && GerritUtil.HadNewChange(pushCommand.CommandOutput, out var changeUri))
                 {
                     FormGerritChangeSubmitted.ShowSubmitted(owner, changeUri);
                 }

src/GitExtensions.GerritPlugin/GerritPlugin.cs

@@ -36,6 +36,8 @@ public class GerritPlugin : GitPluginBase, IGitPluginForRepository
         private const string DefaultPublishTargetBranch = "local";
 
         private readonly BoolSetting _gerritEnabled = new("Gerrit plugin enabled", true);
+        private readonly BoolSetting _gerritShowChangeSubmittedDialog = new("Show change submitted dialog", false);
+
         private readonly ChoiceSetting _predefinedGerritVersion = new(
             "Treat Gerrit as having version",
             new[] { DefaultGerritVersion, "Older then 2.15" },
@@ -307,8 +309,9 @@ private void publishMenuItem_Click(object sender, EventArgs e)
                 ? GerritCapabilities.Version2_15
                 : GerritCapabilities.OldestVersion;
             var shouldTargetLocalBranch = _predefinedPublishTargetBranch.ValueOrDefault(Settings) == DefaultPublishTargetBranch;
+            var showChangeSubmittedDialog = _gerritShowChangeSubmittedDialog.ValueOrDefault(Settings);
 
-            using (var form = new FormGerritPublish(_gitUiCommands, capabilities, shouldTargetLocalBranch))
+            using (var form = new FormGerritPublish(_gitUiCommands, capabilities, shouldTargetLocalBranch, showChangeSubmittedDialog))
             {
                 form.ShowDialog(_mainForm);
             }
@@ -479,6 +482,7 @@ public override bool Execute(GitUIEventArgs args)
         public override IEnumerable<ISetting> GetSettings()
         {
             yield return _gerritEnabled;
+            yield return _gerritShowChangeSubmittedDialog;
             yield return _predefinedGerritVersion;
             yield return _hidePushButton;
             yield return _predefinedPublishTargetBranch;