(refs #1)Change to disable email notification using ajaxPost.

Author: shimamoto

src/main/scala/Plugin.scala

@@ -72,7 +72,7 @@ class Plugin extends gitbucket.core.plugin.Plugin {
         Link(
           id    = "notifications",
           label = "Notifications",
-          path  = s"/${account.userName}/_notifications"
+          path  = s"${account.userName}/_notifications"
         )
       }
   )

src/main/scala/gitbucket/notifications/controller/NotificationsController.scala

@@ -42,11 +42,11 @@ trait NotificationsControllerBase extends ControllerBase {
     } getOrElse NotFound()
   })
 
-  post("/:userName/_notifications")(oneselfOnly {
+  ajaxPost("/:userName/_notifications")(oneselfOnly {
     val userName = params("userName")
     params.getAs[Boolean]("disable").map { disable =>
       updateEmailNotification(userName, disable)
-      redirect(s"/${userName}/_notifications")
+      Ok()
     } getOrElse NotFound()
   })
 

src/main/twirl/gitbucket/notifications/settings.scala.html

@@ -3,20 +3,24 @@
 
 @gitbucket.core.html.main("Notifications"){
   @gitbucket.core.account.html.menu("notifications", account.userName, account.isGroupAccount){
-    <form method="POST" action="@context.path/@account.userName/_notifications">
-      <div class="panel panel-default">
-        <div class="panel-heading strong">Email notification preferences</div>
-        <div class="panel-body">
-          <fieldset class="form-group">
-            <p class="muted">If checked, never be notified of anything.</p>
-            <label for="disable">
-              <input type="checkbox" name="disable" id="disable" value="true" @if(disableEmail){checked}/>
-              Disable
-            </label>
-          </fieldset>
-          <input type="submit" class="btn btn-success" value="Save"/>
-        </div>
+    <div class="panel panel-default">
+      <div class="panel-heading strong">Email notification preferences</div>
+      <div class="panel-body">
+        <fieldset class="form-group">
+          <p class="muted">If checked, never be notified of anything.</p>
+          <label for="disable">
+            <input type="checkbox" name="disable" id="disable" value="true" @if(disableEmail){checked}/>
+            Disable
+          </label>
+        </fieldset>
       </div>
-    </form>
+    </div>
   }
-}
+}
+<script>
+$(function(){
+  $('#disable').click(function(){
+    $.post('@context.path/@account.userName/_notifications', { 'disable': this.checked });
+  });
+});
+</script>