modified code as review comment

Author: tkgdsg

src/main/scala/gitbucket/gist/controller/GistController.scala

@@ -70,6 +70,17 @@ trait GistControllerBase extends ControllerBase {
     _gist(params("userName"), Some(params("repoName")))
   }
 
+  get("/gist/:userName/:repoName.js"){
+    val userName = params("userName")
+    val repoName = params("repoName")
+    getGist(userName, repoName) match {
+      case Some(gist) =>
+        _embedJs(gist, userName, repoName, "master")
+      case None =>
+        NotFound()
+    }
+  }
+
   get("/gist/:userName/:repoName/:revision"){
     _gist(params("userName"), Some(params("repoName")), params("revision"))
   }
@@ -417,12 +428,7 @@ trait GistControllerBase extends ControllerBase {
   ////////////////////////////////////////////////////////////////////////////////
 
 
-  private def _gist(userName: String, repoName: Option[String] = None, revision: String = "master", isEmbed: Boolean = false): Any = {
-
-    if( repoName.isDefined && repoName.get.endsWith(".js")) {
-      return _gist(userName, Some(repoName.get.substring(0,repoName.get.length()-3)), revision, true)
-    }
-
+  private def _gist(userName: String, repoName: Option[String] = None, revision: String = "master"): Any = {
     repoName match {
       case None => {
         val page = params.get("page") match {
@@ -450,14 +456,11 @@ trait GistControllerBase extends ControllerBase {
           case Some(gist) =>
             if(gist.mode == "PRIVATE"){
               context.loginAccount match {
-                case Some(x) if(x.userName == userName) => 
-                                if(isEmbed) _embedJs(gist, userName, repoName, revision)
-                                else       _gistDetail(gist, userName, repoName, revision)
+                case Some(x) if(x.userName == userName) => _gistDetail(gist, userName, repoName, revision)
                 case _ => Unauthorized()
               }
             } else {
-              if(isEmbed) _embedJs(gist, userName, repoName, revision)
-              else       _gistDetail(gist, userName, repoName, revision)
+              _gistDetail(gist, userName, repoName, revision)
             }
           case None =>
             NotFound()

src/main/twirl/gitbucket/gist/detail.scala.js

@@ -4,12 +4,6 @@
   files: Seq[(String, String)]
   )(implicit context: gitbucket.core.controller.Context)
 @import gitbucket.core.view.helpers
-@import play.twirl.api.Html
-@bootstrapCSS={<link href="@helpers.assets("/vendors/bootstrap-3.3.6/css/bootstrap.css")" rel="stylesheet">}
-@prettifyCSS={<link href="@helpers.assets("/vendors/google-code-prettify/prettify.css")" rel="stylesheet">}
-@gistCSS={<link href="@context.path/plugin-assets/gist/style.css" rel="stylesheet">}
-@gitbucketCSS={<link href="@helpers.assets("/common/css/gitbucket.css")" rel="stylesheet">}
-@adminLTECSS={<link href="@helpers.assets("/vendors/AdminLTE-2.3.8/css/AdminLTE.min.css")" rel="stylesheet">}
 jqueryScript = document.createElement('script');
 jqueryScript.src = '@helpers.assets("/vendors/jquery/jquery-1.12.2.min.js")';
 document.head.appendChild(jqueryScript);
@@ -52,9 +46,9 @@ var _html = (function () {/*4f85e035-2513-453b-b435-33f0a12b2339
   </div>
 4f85e035-2513-453b-b435-33f0a12b2339*/}).toString().replace(/(\n)/g, '').split('4f85e035-2513-453b-b435-33f0a12b2339')[1];
 
-document.write('@bootstrapCSS');
-document.write('@prettifyCSS');
-document.write('@gistCSS');
-document.write('@gitbucketCSS');
-document.write('@adminLTECSS');
+document.write('<link href="@helpers.assets("/vendors/bootstrap-3.3.6/css/bootstrap.css")" rel="stylesheet">');
+document.write('<link href="@helpers.assets("/vendors/google-code-prettify/prettify.css")" rel="stylesheet">');
+document.write('<link href="@context.path/plugin-assets/gist/style.css" rel="stylesheet">');
+document.write('<link href="@helpers.assets("/common/css/gitbucket.css")" rel="stylesheet">');
+document.write('<link href="@helpers.assets("/vendors/AdminLTE-2.3.8/css/AdminLTE.min.css")" rel="stylesheet">');
 document.write(_html.replace(/\\r\\n/g,"\n").replace(/\\/g,""));