-
Notifications
You must be signed in to change notification settings - Fork 25
Implement hands on hp-sync-upstream #97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
vanphuc1201
wants to merge
6
commits into
git-mastery:main
Choose a base branch
from
vanphuc1201:branch-hp-sync-upstream
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
8ab9a3b
Add hans on hp-sync-upstream
vanphuc1201 efdc462
Change the name of the hands on
vanphuc1201 743b8aa
Delete the existing file with the same name
vanphuc1201 efbef42
Add the tag for the first commit
vanphuc1201 50c9f40
Change the doc
vanphuc1201 20b67f2
Add more checking logic
vanphuc1201 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| import os | ||
| import sys | ||
| import shutil | ||
| from exercise_utils.cli import run_command, run_command_no_exit | ||
|
|
||
| __requires_git__ = True | ||
| __requires_github__ = True | ||
|
|
||
|
|
||
| def _get_full_repo_name(verbose: bool) -> str: | ||
| """Get the full GitHub repository name for the authenticated user.""" | ||
| output = run_command(["gh", "api", "user", "-q", ".login"], verbose) | ||
| username = output.strip() if output else "" | ||
| return f"{username}/{"samplerepo-finances"}" | ||
|
|
||
| def download(verbose: bool): | ||
| full_repo_name = _get_full_repo_name(verbose) | ||
| output = run_command_no_exit(["gh", "repo", "view", full_repo_name], verbose) | ||
|
|
||
| if output is not None: | ||
| print( | ||
| f"\nRepository 'https://github.com/{full_repo_name}' already exists on GitHub.\n" | ||
| "Please delete the existing fork before proceeding." | ||
| ) | ||
| sys.exit(1) | ||
|
|
||
| if os.path.exists("samplerepo-finances"): | ||
| shutil.rmtree("samplerepo-finances") | ||
|
|
||
| run_command([ | ||
| "gh", "repo", "fork", | ||
| "https://github.com/git-mastery/samplerepo-finances", | ||
| "--clone", | ||
| "--remote" | ||
| ], verbose) | ||
|
Comment on lines
+30
to
+35
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Seems like we ultimately want these to be util functions. I'm good keeping things this way for now since it's more effort to try to coordinate the changes. We'll need to track this as future work to de-duplicate common behavior @damithc |
||
|
|
||
| os.chdir("samplerepo-finances") | ||
|
|
||
| run_command([ | ||
| "git", "remote", "add", "upstream", | ||
| "https://github.com/git-mastery/samplerepo-finances" | ||
| ], verbose) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might also want to check that the fork does not exist yet. If it does, we want to delete it. This is being discussed in #78. I would like if we are aligned on the approach of displaying a message to tell the user to delete the fork themselves, then re-running the fork command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so much, i have add the command to check it.