Skip to content

Conversation

@MousseDm
Copy link

@MousseDm MousseDm commented Oct 27, 2025

Exercise Review

Exercise Discussion

#58

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@MousseDm MousseDm changed the title Hands-on(ignore-file): add sandbox for ignore file Implement hands on hp-ignore-file Oct 27, 2025
@damithc damithc requested a review from Copilot November 2, 2025 12:38
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new hands-on exercise that demonstrates how .gitignore files work in Git. The exercise creates a sandbox repository with a .gitignore file and demonstrates which files are tracked versus ignored.

  • Creates a new ignore_file.py module in the hands_on directory
  • Sets up a Git repository with a .gitignore that excludes logs/ directory and *.tmp files
  • Demonstrates tracked vs. ignored files by creating files that match ignore patterns

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Member

@woojiahao woojiahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MousseDm Curious but where did you get the instructions for the download function? The hands-on discussion you linked includes the equivalent Bash commands for creating the sandbox.

If you can implement the instructions as per the approved hands-on discussion, that would be good!

@MousseDm
Copy link
Author

I see why my earlier implementation used a sandbox/ directory.
I was following the general contributor documentation on creating hands-ons, which describes how the Git-Mastery App sets up a sandbox for students to do the practical and I assumed each hands-on should therefore create its own sandbox/ folder as the working directory.
image

I have already rechecked the issue #58 and updated my script accordingly so it shall match the steps now.

Also, I notice that for exercises, the structure for each is something like:
hp_ignore_file/
├─ .gitmastery-exercise.json
├─ README.md
├─ init.py
├─ download.py
├─ verify.py
├─ tests
Should I also modify the hp structure like this?

Thanks for pointing me in the right direction!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Hands-On Discussion] T2L6/hp-ignore-file (Adding a file to the ignore list)

2 participants