Implement hands on hp-force-push #116
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woojiahao
reviewed
Nov 10, 2025
hands_on/force_push.py
Outdated
Comment on lines
14
to
17
| """ | ||
| hp-force-push (T4L5) | ||
| - Fork https://github.com/git-mastery/samplerepo-things to user account as "samplerepo-things-force-push" | ||
| - Clone the fork locally as 'samplerepo-things' |
hands_on/force_push.py
Outdated
Comment on lines
20
to
22
| gh_username = run_command(["gh", "api", "user", "-q", ".login"], verbose) | ||
| if not gh_username: | ||
| raise RuntimeError("Your Github CLI is not setup correctly") |
Member
There was a problem hiding this comment.
This is what __requires_github__ does, so this is not necessary
Comment on lines
+29
to
+43
| run_command( | ||
| [ | ||
| "gh", | ||
| "repo", | ||
| "fork", | ||
| UPSTREAM_REPO, | ||
| "--default-branch-only", | ||
| "--fork-name", | ||
| REPO_NAME, | ||
| "--clone=true", | ||
| "--", | ||
| WORK_DIR, | ||
| ], | ||
| verbose, | ||
| ) |
Member
There was a problem hiding this comment.
This is pending comments from @damithc on the original hands-on discussion, but I don't think we need to fork the repository, cloning using git should be sufficient
hands_on/force_push.py
Outdated
Comment on lines
45
to
46
| if not work_dir.is_dir(): | ||
| raise RuntimeError("Fork/clone failed") |
Member
There was a problem hiding this comment.
run_command would already catch if the command errors out
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise Review
Exercise Discussion
#108
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?