Implement hands-on checkout commits #113
Conversation
woojiahao
left a comment
woojiahao
left a comment
There was a problem hiding this comment.
Left some comments. Could you also remove the comments for the steps. They aren't necessary.
| __requires_github__ = False | ||
|
|
||
| def download(verbose: bool): | ||
| """ |
| target_dir = Path("things") | ||
|
|
||
| # Clean existing sandbox if re-downloading | ||
| if target_dir.exists(): | ||
| import shutil | ||
| shutil.rmtree(target_dir) |
There was a problem hiding this comment.
This already happens via the app: https://git-mastery.github.io/developers/docs/architecture/download-workflow/#hands-on-download
So this check can be omitted
| # Create sandbox folder | ||
| target_dir.mkdir() | ||
| os.chdir(target_dir) |
There was a problem hiding this comment.
I think conventionally, os.makedirs would be more consistent with the existing code
| with open("fruits.txt", "w") as f: | ||
| f.write("apples\nbananas\ncherries\ndragon fruits\n") |
There was a problem hiding this comment.
Please use the given create_or_update_file utility function
| with open("fruits.txt", "a") as f: | ||
| f.write("elderberries\nfigs\n") |
There was a problem hiding this comment.
Please use the given append_file utility function
| with open("colours.txt", "w") as f: | ||
| f.write("a file for colours\n") | ||
| with open("shapes.txt", "w") as f: | ||
| f.write("a file for shapes\n") |
There was a problem hiding this comment.
Use the given create_or_update_file utility function
| with open("fruits.txt", "w") as f: | ||
| f.write("apples, apricots\nbananas\nblueberries\ncherries\ndragon fruits\nfigs\n") |
There was a problem hiding this comment.
Use the given create_or_update utility function
| with open("colours.txt", "a") as f: | ||
| f.write("blue\nred\nwhite\n") |
| with open("shapes.txt", "a") as f: | ||
| f.write("circle\noval\nrectangle\nsquare\n") |
2 participants
Exercise Review
Exercise Discussion
#106
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?