Implement hands on hp-diff-changes #112
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woojiahao
requested changes
Nov 10, 2025
|
|
||
| create_or_update_file( | ||
| "colours.txt", | ||
| "a file for colours\n", |
Member
There was a problem hiding this comment.
Suggested change
| "a file for colours\n", | |
| "a file for colours", |
Author
There was a problem hiding this comment.
I don't think here should remove the escape sequence. The targeted colour.txt should be
a file for colours
blue
red
white
While if removed, will be
a file for coloursblue
red
white
| ) | ||
| create_or_update_file( | ||
| "shapes.txt", | ||
| "a file for shapes\n", |
Member
There was a problem hiding this comment.
Suggested change
| "a file for shapes\n", | |
| "a file for shapes", |
Author
There was a problem hiding this comment.
Same reason as colour.txt, here I think we should keep the \n
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise Review
Exercise Discussion
Link the exercise discussion issue #105
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?