Skip to content

Implement hands on hp-view-commits #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Implement hands on hp-view-commits #104

wants to merge 1 commit into from

Conversation

@keerthigkaarthik
Copy link

@keerthigkaarthik keerthigkaarthik commented Nov 1, 2025 •
edited
Loading

Exercise Review

Exercise Discussion

#90

Checklist

  • If you require a new remote repository on the Git-Mastery organization, have you created a request for it?
  • Have you written unit tests using repo-smith to validate the exercise grading scheme?
  • Have you tested the download script using test-download.sh?
  • Have you verified that this exercise does not already exist or is not currently in review?
  • Did you introduce a new grading mechanism that should belong to git-autograder?
  • Did you introduce a new dependency that should belong to app?

@damithc damithc linked an issue Nov 2, 2025 that may be closed by this pull request
[Hands-On Discussion] T4L1/hp-view-commits (View specific commits) #90
Open
woojiahao
woojiahao requested changes Nov 10, 2025
View reviewed changes
Copy link
Member

@woojiahao woojiahao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some minor nits

hands_on/view_commits.py

create_or_update_file(
"fruits.txt",
"apples\nbananas\ncherries\ndragon fruits\n",
Copy link
Member

@woojiahao woojiahao Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a multi-line string to avoid \n

hands_on/view_commits.py

create_or_update_file(
"fruits.txt",
"apples, apricots\nbananas\nblueberries\ncherries\ndragon fruits\nfigs\n",
Copy link
Member

@woojiahao woojiahao Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a multi-line string to avoid \n

hands_on/view_commits.py
"apples, apricots\nbananas\nblueberries\ncherries\ndragon fruits\nfigs\n",
)
add(["fruits.txt"], verbose)
commit("Update fruits list", verbose) No newline at end of file
Copy link
Member

@woojiahao woojiahao Nov 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
commit("Update fruits list", verbose)
commit("Update fruits list", verbose)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@woojiahao woojiahao woojiahao requested changes

Assignees

No one assigned

Labels

discussing hands-on review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Hands-On Discussion] T4L1/hp-view-commits (View specific commits)

2 participants

@keerthigkaarthik @woojiahao