-
Notifications
You must be signed in to change notification settings - Fork 25
Implement hands on hp-push-tags #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
I'm not sure what to do when there's a conflict in repo names, i.e., the user already has a repo named |
We can use an alternative fork name such as |
Sure! Maybe I can submit follow-up commits regarding this later. |
|
The follow-up commits are up! |
woojiahao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is pending some comments from @damithc on the original hands-on discussion. Let's come back to this once he confirms if we need to fork the repository.
| tag_with_options("v1.0", ["HEAD~1"], verbose) | ||
| annotated_tag_with_options("v0.9", ["HEAD~2", "-m", "First beta release"], verbose) | ||
|
|
||
| pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| pass |
| check_existing_fork(username, "git-mastery", REPO_NAME) | ||
| check_same_repo_name(username, REPO_NAME) | ||
|
|
||
| run_command(["gh", "repo", "fork", f"git-mastery/{REPO_NAME}", REPO_NAME, "--clone"], verbose) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left a comment for @damithc in the original hands-on discussion, but I doubt we actually need to fork the repository for the student. This would avoid polluting the student's Github with excessive repositories they might not be using
Exercise Review
Exercise Discussion
#94
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?