Implement hands on hp-pull-remote #100
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
woojiahao
requested changes
Nov 10, 2025
Member
woojiahao
left a comment
woojiahao
left a comment
There was a problem hiding this comment.
@lavanyagarg112 You might want to reference #99 too to compare and see if there's anything that could be the same since the setup is equivalent
| from exercise_utils.git import clone | ||
|
|
||
| __requires_git__ = True | ||
| __requires_github__ = True |
Member
There was a problem hiding this comment.
Suggested change
| __requires_github__ = True | |
| __requires_github__ = False |
This can be set to False if you do not use gh as part of the script
| os.makedirs("samplerepo-finances") | ||
| clone("https://github.com/git-mastery/samplerepo-finances.git", verbose) | ||
| os.chdir("samplerepo-finances") | ||
| run_command(["git", "remote", "set-url", "origin", "https://github.com/git-mastery/samplerepo-finances-2.git"], verbose) No newline at end of file |
Member
There was a problem hiding this comment.
Suggested change
| run_command(["git", "remote", "set-url", "origin", "https://github.com/git-mastery/samplerepo-finances-2.git"], verbose) | |
| run_command(["git", "remote", "set-url", "origin", "https://github.com/git-mastery/samplerepo-finances-2.git"], verbose) | |
| os.makedirs("samplerepo-finances") | ||
| clone("https://github.com/git-mastery/samplerepo-finances.git", verbose) | ||
| os.chdir("samplerepo-finances") | ||
| run_command(["git", "remote", "set-url", "origin", "https://github.com/git-mastery/samplerepo-finances-2.git"], verbose) No newline at end of file |
Member
There was a problem hiding this comment.
Also curious what the rationale behind abstracting clone to a utility function but not set-url?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exercise Review
Exercise Discussion
#87
Checklist
Git-Masteryorganization, have you created a request for it?repo-smithto validate the exercise grading scheme?test-download.sh?git-autograder?app?