odb_load_loose_cache: fix strbuf leak

peff · gitster · commit 7317aa7153c0 · 2018-11-24T11:13:24.000+09:00
Commit 3a2e082 ("object-store: provide helpers for loose_objects_cache", 2018-11-12) moved the cache-loading code from find_short_object_filename(), but forgot the line that releases the path strbuf. Reported-by: René Scharfe <l.s.r@web.de> Signed-off-by: Jeff King <peff@peff.net> Signed-off-by: Junio C Hamano <gitster@pobox.com>
diff --git a/sha1-file.c b/sha1-file.c
@@ -2169,6 +2169,7 @@ void odb_load_loose_cache(struct object_directory *odb, int subdir_nr)
 				    NULL, NULL,
 				    &odb->loose_objects_cache);
 	odb->loose_objects_subdir_seen[subdir_nr] = 1;
+	strbuf_release(&buf);
 }
 
 static int check_stream_sha1(git_zstream *stream,

Original file line number	Diff line number	Diff line change
`@@ -2169,6 +2169,7 @@ void odb_load_loose_cache(struct object_directory *odb, int subdir_nr)`
`2169`	`2169`	`NULL, NULL,`
`2170`	`2170`	`&odb->loose_objects_cache);`
`2171`	`2171`	`odb->loose_objects_subdir_seen[subdir_nr] = 1;`
	`2172`	`+ strbuf_release(&buf);`
`2172`	`2173`	`}`
`2173`	`2174`
`2174`	`2175`	`static int check_stream_sha1(git_zstream *stream,`