Merge branch 'rs/no-mode-to-open-when-appending'

gitster · gitster · commit 2a6d0b2b6879 · 2021-09-20T15:20:45.000-07:00
The "mode" word is useless in a call to open(2) that does not
create a new file.  Such a call in the files backend of the ref
subsystem has been cleaned up.

* rs/no-mode-to-open-when-appending:
  refs/files-backend: remove unused open mode parameter
diff --git a/refs/files-backend.c b/refs/files-backend.c
@@ -1569,7 +1569,7 @@ static int log_ref_setup(struct files_ref_store *refs,
 			goto error;
 		}
 	} else {
-		*logfd = open(logfile, O_APPEND | O_WRONLY, 0666);
+		*logfd = open(logfile, O_APPEND | O_WRONLY);
 		if (*logfd < 0) {
 			if (errno == ENOENT || errno == EISDIR) {
 				/*

Original file line number	Diff line number	Diff line change
`@@ -1569,7 +1569,7 @@ static int log_ref_setup(struct files_ref_store *refs,`
`1569`	`1569`	`goto error;`
`1570`	`1570`	`}`
`1571`	`1571`	`} else {`
`1572`		`- *logfd = open(logfile, O_APPEND \| O_WRONLY, 0666);`
	`1572`	`+ *logfd = open(logfile, O_APPEND \| O_WRONLY);`
`1573`	`1573`	`if (*logfd < 0) {`
`1574`	`1574`	`if (errno == ENOENT \|\| errno == EISDIR) {`
`1575`	`1575`	`/*`