push: do not pretend to return int from die_push_simple()

dscho · dscho · commit 0a8bdb71852f · 2019-04-10T14:11:26.000+02:00
This function is marked as `NORETURN`, and it indeed does not want to
return anything. So let's not declare it with the return type `int`.
This fixes the following warning when building with MSVC:

	C4646: function declared with 'noreturn' has non-void return type

Signed-off-by: Johannes Schindelin &lt;johannes.schindelin@gmx.de&gt;
diff --git a/builtin/push.c b/builtin/push.c
@@ -143,8 +143,8 @@ static int push_url_of_remote(struct remote *remote, const char ***url_p)
 	return remote->url_nr;
 }
 
-static NORETURN int die_push_simple(struct branch *branch,
-				    struct remote *remote)
+static NORETURN void die_push_simple(struct branch *branch,
+				     struct remote *remote)
 {
 	/*
 	 * There's no point in using shorten_unambiguous_ref here,

Original file line number	Diff line number	Diff line change
`@@ -143,8 +143,8 @@ static int push_url_of_remote(struct remote remote, const char **url_p)`
`143`	`143`	`return remote->url_nr;`
`144`	`144`	`}`
`145`	`145`
`146`		`-static NORETURN int die_push_simple(struct branch *branch,`
`147`		`- struct remote *remote)`
	`146`	`+static NORETURN void die_push_simple(struct branch *branch,`
	`147`	`+ struct remote *remote)`
`148`	`148`	`{`
`149`	`149`	`/*`
`150`	`150`	`* There's no point in using shorten_unambiguous_ref here,`