Allow initialization once per run (with multiple modules)

[tuukkamustonen]

buildnumber-maven-plugin has http://mojo.codehaus.org/buildnumber-maven-plugin/create-mojo.html#getRevisionOnlyOnce to fetch the details only once.

With git-commit-id-plugin there is no such open and each module will re-fetch the details.

I tried declaring the plugin on parent POM and setting inherited to false, but then ${git.*} properties don't seem to be available on child modules (even though parent seems to successfully fetch the details).

[ktoso]

Yes, definitely makes sense.

Let's try to include a fix for this in 2.1.4 :)

[lenkite]

Would love to have this feature. With multiple modules, this plugin adds significantly to the build time.

[ktoso]

I'm a bit worried about submodules and how to handle them... I'll try to develop on a sample project with many modules and we'll see how it goes :)

[nathanlws]

👍

[dtrucken]

Is there any progress on this? I have a project with 35 modules I could test it on

[ktoso]

You're more than welcome to try contributing then :-) I won't be taking it
up in threat future.

Konrad
(sent from mobile)
On 2 Dec 2014 01:36, "dtrucken" notifications@github.com wrote:

Is there any progress on this? I have a project with 35 modules I could
test it on

—
Reply to this email directly or view it on GitHub
#53 (comment)
.

[dtrucken]

Ok,
Let me see what I can do today, and if it works.
Dave

On Mon, Dec 1, 2014 at 9:15 PM, Konrad Malawski notifications@github.com
wrote:

You're more than welcome to try contributing then :-) I won't be taking it
up in threat future.

Konrad
(sent from mobile)
On 2 Dec 2014 01:36, "dtrucken" notifications@github.com wrote:

Is there any progress on this? I have a project with 35 modules I could
test it on

—
Reply to this email directly or view it on GitHub
<
https://github.com/ktoso/maven-git-commit-id-plugin/issues/53#issuecomment-65164866>

.

—
Reply to this email directly or view it on GitHub
#53 (comment)
.

[ktoso]

Cool, feel free to ping this issue if you run into any trouble or would
need advice.
Sadly I won't be able to pour coding time into this right now, but I may be
able to help in other ways

Konrad 'ktoso’ Malawski
hAkker @ typesafe
akka.io / java.pl / geecon.org / krakowscala.pl / gdgkrakow.pl

2014-12-02 13:07 GMT+01:00 dtrucken notifications@github.com:

Ok,
Let me see what I can do today, and if it works.
Dave

On Mon, Dec 1, 2014 at 9:15 PM, Konrad Malawski notifications@github.com

wrote:

You're more than welcome to try contributing then :-) I won't be taking
it
up in threat future.

Konrad
(sent from mobile)
On 2 Dec 2014 01:36, "dtrucken" notifications@github.com wrote:

Is there any progress on this? I have a project with 35 modules I
could
test it on

—
Reply to this email directly or view it on GitHub
<

https://github.com/ktoso/maven-git-commit-id-plugin/issues/53#issuecomment-65164866>

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/ktoso/maven-git-commit-id-plugin/issues/53#issuecomment-65177627>

.

—
Reply to this email directly or view it on GitHub
#53 (comment)
.

[dtrucken]

Hi Konrad,

Not sure about your checkin system, and I'm not sure I'd want my name
attached to anything anyway... :-)

The fix is pretty simple, in GitCommitIdMojo.java we need to add these bits:

-->line 28 (or somewhere near the top)
import org.apache.maven.execution.MavenSession;

-->line 259 (or after the private boolean skip;)
/**

• In a multimodule build, only run once
  *

• @parameter default-value="false"

• @SInCE 2.1.12
  */
  @SuppressWarnings("UnusedDeclaration")
  private boolean runOnlyOnce = false;

  /**

  • The Maven Session Object
    *
  • @parameter expression="${session}"
  • @required
  • @readonly
    */
    @SuppressWarnings("UnusedDeclaration")
    protected MavenSession session;

-->line 293 (315 after the above insert, or after the if (skip) { } block)
if (runOnlyOnce) {
if
(!session.getExecutionRootDirectory().equals(session.getCurrentProject().getBasedir().getAbsolutePath()))
{
log("already run once, return");
return;
}
}

---

This creates a new dependency for the Maven Session object, so in the
pom.xml you'll need to add:

org.apache.maven
maven-core
${maven-plugin-api.version}

---

Dave

On Tue, Dec 2, 2014 at 7:10 AM, Konrad Malawski notifications@github.com
wrote:

Cool, feel free to ping this issue if you run into any trouble or would
need advice.
Sadly I won't be able to pour coding time into this right now, but I may
be
able to help in other ways

Konrad 'ktoso’ Malawski
hAkker @ typesafe
akka.io / java.pl / geecon.org / krakowscala.pl / gdgkrakow.pl

2014-12-02 13:07 GMT+01:00 dtrucken notifications@github.com:

Ok,
Let me see what I can do today, and if it works.
Dave

On Mon, Dec 1, 2014 at 9:15 PM, Konrad Malawski <
notifications@github.com>

wrote:

You're more than welcome to try contributing then :-) I won't be
taking
it
up in threat future.

Konrad
(sent from mobile)
On 2 Dec 2014 01:36, "dtrucken" notifications@github.com wrote:

Is there any progress on this? I have a project with 35 modules I
could
test it on

—
Reply to this email directly or view it on GitHub
<

https://github.com/ktoso/maven-git-commit-id-plugin/issues/53#issuecomment-65164866>

.

—
Reply to this email directly or view it on GitHub
<

https://github.com/ktoso/maven-git-commit-id-plugin/issues/53#issuecomment-65177627>

.

—
Reply to this email directly or view it on GitHub
<
https://github.com/ktoso/maven-git-commit-id-plugin/issues/53#issuecomment-65221736>

.

—
Reply to this email directly or view it on GitHub
#53 (comment)
.

[ktoso]

well, it's just git - you could even edit the file online: https://github.com/ktoso/maven-git-commit-id-plugin/blob/master/src/main/java/pl/project13/maven/git/GitCommitIdMojo.java

Would be cool if you could edit it and send in a pull request, a contribution is a contribution after all, so I'd like to give credit where it's due ;-)

Are you sure such fix will always do the right thing?
What if we write to a git.properties file - then each sub project must generate it by itself, right?
So this should perhaps be an exposed option instead of hardcoding?

[dtrucken]

OK, I'll give it a whirl when I get to the computer. When is the scheduled
date for the next release?
On Dec 3, 2014 3:34 AM, "Konrad Malawski" notifications@github.com wrote:

well, it's just git - you could even edit the file online:
https://github.com/ktoso/maven-git-commit-id-plugin/blob/master/src/main/java/pl/project13/maven/git/GitCommitIdMojo.java

Would be cool if you could edit it and send in a pull request, a
contribution is a contribution after all, so I'd like to give credit where
it's due ;-)

—
Reply to this email directly or view it on GitHub
#53 (comment)
.

[ktoso]

This project is most of the time released whenever I'm bored at an airport... this saturday again ;-)

But seriously though: whenever there's a feature that deserves to get out soon I just cut a release the same day I merge something usually.

[dtrucken]

If you use the new proposed option with git.properties, then only a single git.properties file would be created in the directory where you started the execution. The new proposed option won't do "the right thing" if you have multiple git repositories either. The default is "false", or not to change behavior. But, the feature is useful (saves minutes) on a 35 modules product if you do something like:

        <plugin>
            <groupId>org.apache.maven.plugins</groupId>
            <artifactId>maven-jar-plugin</artifactId>
            <configuration>
                <archive>
                    <addMavenDescriptor>false</addMavenDescriptor>
                    <manifest>
                        <addClasspath>true</addClasspath>
                        <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
                        <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
                        <packageName>${project.groupId}</packageName>
                    </manifest>
                    <manifestEntries>
                        <Git-Branch>${git.branch}</Git-Branch>
                        <Git-Build-Time>${git.build.time}</Git-Build-Time>
                        <Git-Commit-Id-Abbrev>${git.commit.id.abbrev}</Git-Commit-Id-Abbrev>
                        <Git-Commit-Id>${git.commit.id}</Git-Commit-Id>
                        <Git-Build-User-Name>${git.build.user.name}</Git-Build-User-Name>
                    </manifestEntries>
                </archive>
            </configuration>
        </plugin>