Skip to content

Commit c1443b5

Browse files
committed
Merge pull request #179 from katox/master
JGit and other updates
2 parents 4ecc3cc + f4fa04f commit c1443b5

File tree

4 files changed

+7
-11
lines changed

4 files changed

+7
-11
lines changed

pom.xml

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -69,9 +69,9 @@
6969
</scm>
7070

7171
<properties>
72-
<maven-plugin-api.version>2.2.1</maven-plugin-api.version>
72+
<maven-plugin-api.version>3.1.1</maven-plugin-api.version>
7373

74-
<jgit.version>3.4.1.201406201815-r</jgit.version>
74+
<jgit.version>3.7.0.201502260915-r</jgit.version>
7575
<junit.version>4.12</junit.version>
7676
<mockito.version>2.0.5-beta</mockito.version>
7777

@@ -93,11 +93,6 @@
9393
<artifactId>maven-core</artifactId>
9494
<version>${maven-plugin-api.version}</version>
9595
</dependency>
96-
<dependency>
97-
<groupId>org.apache.maven</groupId>
98-
<artifactId>maven-project</artifactId>
99-
<version>${maven-plugin-api.version}</version>
100-
</dependency>
10196

10297
<dependency>
10398
<groupId>com.fasterxml.jackson.core</groupId>

src/main/java/pl/project13/maven/git/GitCommitIdMojo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -295,7 +295,7 @@ public class GitCommitIdMojo extends AbstractMojo {
295295
/**
296296
* The Maven Session Object
297297
*
298-
* @parameter expression="${session}"
298+
* @parameter property="session"
299299
* @required
300300
* @readonly
301301
*/

src/main/java/pl/project13/maven/git/JGitProvider.java

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,6 +3,7 @@
33
import com.google.common.annotations.VisibleForTesting;
44
import com.google.common.base.Function;
55
import com.google.common.base.Joiner;
6+
import com.google.common.base.MoreObjects;
67
import com.google.common.base.Objects;
78
import com.google.common.base.Predicate;
89
import com.google.common.collect.Collections2;
@@ -69,13 +70,13 @@ protected void init() throws MojoExecutionException {
6970
@Override
7071
protected String getBuildAuthorName() {
7172
String userName = git.getConfig().getString("user", null, "name");
72-
return Objects.firstNonNull(userName, "");
73+
return MoreObjects.firstNonNull(userName, "");
7374
}
7475

7576
@Override
7677
protected String getBuildAuthorEmail() {
7778
String userEmail = git.getConfig().getString("user", null, "email");
78-
return Objects.firstNonNull(userEmail, "");
79+
return MoreObjects.firstNonNull(userEmail, "");
7980
}
8081

8182
@Override

src/test/java/pl/project13/maven/git/FileSystemMavenSandbox.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,7 +168,7 @@ public MavenProject getChildProject() {
168168
@NotNull
169169
private MavenProject createProject(File basedir, String packaging) {
170170
MavenProject project = new MavenProject();
171-
project.setBasedir(basedir);
171+
project.setFile(new File(basedir + FILE_SEPARATOR + "pom.xml"));
172172
project.setPackaging(packaging);
173173
return project;
174174
}

0 commit comments

Comments
 (0)