Skip to content

Commit 9311fe7

Browse files
committed
Changed: short-describe to describe-short
Refs #111
1 parent 020662f commit 9311fe7

File tree

3 files changed

+9
-3
lines changed

3 files changed

+9
-3
lines changed

README.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -280,6 +280,7 @@ import org.codehaus.jackson.annotate.JsonWriteNullProperties;
280280
public class GitRepositoryState {
281281
String branch; // =${git.branch}
282282
String describe; // =${git.commit.id.describe}
283+
String shortDescribe; // =${git.commit.id.describe-short}
283284
String commitId; // =${git.commit.id}
284285
String commitIdAbbrev; // =${git.commit.id.abbrev}
285286
String buildUserName; // =${git.build.user.name}
@@ -331,6 +332,7 @@ In the end *this is what this service would return*:
331332
{
332333
"branch" : "testing-maven-git-plugin",
333334
"describe" : "v2.1.0-2-g2346463",
335+
"describeShort" : "v2.1.0-2",
334336
"commitTime" : "06.01.1970 @ 16:16:26 CET",
335337
"commitId" : "787e39f61f99110e74deed68ab9093088d64b969",
336338
"commitIdAbbrev" : "787e39f",
@@ -394,6 +396,7 @@ public GitRepositoryState(Properties properties)
394396
{
395397
this.branch = properties.get("git.branch").toString();
396398
this.describe = properties.get("git.commit.id.describe").toString();
399+
this.describeShort = properties.get("git.commit.id.describe-short").toString();
397400
this.commitId = properties.get("git.commit.id").toString();
398401
this.buildUserName = properties.get("git.build.user.name").toString();
399402
this.buildUserEmail = properties.get("git.build.user.email").toString();
@@ -452,6 +455,9 @@ Other outputs may look like:
452455

453456
For more details (on when what output will be returned etc), see <code>man git-describe</code> (or here: [git-describe](http://www.kernel.org/pub/software/scm/git/docs/git-describe.html)). In general, you can assume it's a "best effort" approach, to give you as much info about the repo state as possible.
454457

458+
**describe-short** is also provided, in case you want to display this property to non-techy users, which would panic on the sight of a hash (last part of the describe string) - this property is simply
459+
*the describe output, with the hash part stripped out*.
460+
455461
git-describe and a small "gotcha" with tags
456462
-------------------------------------------
457463
You probably know that git has two kinds of tags:

src/main/java/pl/project13/maven/git/GitCommitIdMojo.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,7 @@ public class GitCommitIdMojo extends AbstractMojo {
6666
public static final String COMMIT_ID = "commit.id";
6767
public static final String COMMIT_ID_ABBREV = "commit.id.abbrev";
6868
public static final String COMMIT_DESCRIBE = "commit.id.describe";
69-
public static final String COMMIT_SHORT_DESCRIBE = "commit.id.short-describe";
69+
public static final String COMMIT_SHORT_DESCRIBE = "commit.id.describe-short";
7070
public static final String BUILD_AUTHOR_NAME = "build.user.name";
7171
public static final String BUILD_AUTHOR_EMAIL = "build.user.email";
7272
public static final String BUILD_TIME = "build.time";

src/test/java/pl/project13/maven/git/GitCommitIdMojoIntegrationTest.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ public void shouldGenerateDescribeWithTagOnlyWhenForceLongFormatIsFalse() throws
272272

273273
// then
274274
assertThat(targetProject.getProperties()).includes(entry("git.commit.id.describe", "v1.0.0"));
275-
assertThat(targetProject.getProperties()).includes(entry("git.commit.id.short-describe", "v1.0.0"));
275+
assertThat(targetProject.getProperties()).includes(entry("git.commit.id.describe-short", "v1.0.0"));
276276
}
277277

278278
@Test
@@ -297,7 +297,7 @@ public void shouldGenerateDescribeWithTagAndZeroAndCommitIdWhenForceLongFormatIs
297297

298298
// then
299299
assertThat(targetProject.getProperties()).includes(entry("git.commit.id.describe", "v1.0.0-0-gde4db35"));
300-
assertThat(targetProject.getProperties()).includes(entry("git.commit.id.short-describe", "v1.0.0-0"));
300+
assertThat(targetProject.getProperties()).includes(entry("git.commit.id.describe-short", "v1.0.0-0"));
301301
}
302302

303303
private void alterMojoSettings(String parameterName, Object parameterValue) {

0 commit comments

Comments
 (0)