fix: fix until and while test function logic error.

Author: ghosind

until.go

@@ -48,8 +48,8 @@ func until(parent context.Context, testFn, fn AsyncFn) ([]any, error) {
 			return out, testErr
 		}
 
-		isDone := testOut[0].(bool)
-		if isDone {
+		isContinue := testOut[0].(bool)
+		if !isContinue {
 			return out, nil
 		}
 	}

until_test.go

@@ -14,7 +14,7 @@ func TestUntil(t *testing.T) {
 	count := 0
 
 	out, err := Until(func(c int) bool {
-		return c == 5
+		return c < 5
 	}, func() int {
 		count++
 		return count
@@ -39,22 +39,22 @@ func TestUntilInvalidParameters(t *testing.T) {
 		Until(func() {}, func() {})
 	}, ErrInvalidTestFunc)
 	a.NotPanicNow(func() {
-		Until(func() bool { return true }, func() {})
+		Until(func() bool { return false }, func() {})
 	})
 	a.NotPanicNow(func() {
-		Until(func(err error) bool { return true }, func() error { return nil })
+		Until(func(err error) bool { return false }, func() error { return nil })
 	})
 	a.NotPanicNow(func() {
-		Until(func(ctx context.Context, err error) bool { return true }, func() error { return nil })
+		Until(func(ctx context.Context, err error) bool { return false }, func() error { return nil })
 	})
 	a.NotPanicNow(func() {
-		Until(func(ctx context.Context) bool { return true }, func() error { return nil })
+		Until(func(ctx context.Context) bool { return false }, func() error { return nil })
 	})
 	a.PanicOfNow(func() {
-		Until(func(ctx context.Context, i int) bool { return true }, func() error { return nil })
+		Until(func(ctx context.Context, i int) bool { return false }, func() error { return nil })
 	}, ErrInvalidTestFunc)
 	a.PanicOfNow(func() {
-		Until(func(ctx context.Context, i int) bool { return true }, func() {})
+		Until(func(ctx context.Context, i int) bool { return false }, func() {})
 	}, ErrInvalidTestFunc)
 }
 
@@ -64,7 +64,7 @@ func TestUntilWithFunctionError(t *testing.T) {
 	unexpectedErr := errors.New("unexpected error")
 
 	out, err := Until(func(c int, err error) bool {
-		return c == 5
+		return c < 5
 	}, func() (int, error) {
 		count++
 		return count, unexpectedErr
@@ -96,9 +96,9 @@ func TestUntilWithContext(t *testing.T) {
 	out, err := UntilWithContext(ctx, func(ctx context.Context) bool {
 		select {
 		case <-ctx.Done():
-			return true
-		default:
 			return false
+		default:
+			return true
 		}
 	}, func() {
 	})

while.go

@@ -41,8 +41,8 @@ func while(parent context.Context, testFn, fn AsyncFn) ([]any, error) {
 			return out, testErr
 		}
 
-		isDone := testOut[0].(bool)
-		if isDone {
+		isContinue := testOut[0].(bool)
+		if !isContinue {
 			return out, nil
 		}
 

while_test.go

@@ -14,7 +14,7 @@ func TestWhile(t *testing.T) {
 	count := 0
 
 	out, err := While(func() bool {
-		return count == 5
+		return count < 5
 	}, func() int {
 		count++
 		return count
@@ -39,13 +39,13 @@ func TestWhileInvalidParameters(t *testing.T) {
 		While(func() {}, func() {})
 	}, ErrInvalidTestFunc)
 	a.NotPanicNow(func() {
-		While(func() bool { return true }, func() {})
+		While(func() bool { return false }, func() {})
 	})
 	a.NotPanicNow(func() {
-		While(func(ctx context.Context) bool { return true }, func() {})
+		While(func(ctx context.Context) bool { return false }, func() {})
 	})
 	a.PanicOfNow(func() {
-		While(func(ctx context.Context, i int) bool { return true }, func() {})
+		While(func(ctx context.Context, i int) bool { return false }, func() {})
 	}, ErrInvalidTestFunc)
 }
 
@@ -68,7 +68,7 @@ func TestWhileWithFunctionError(t *testing.T) {
 	expectedErr := errors.New("expected error")
 
 	out, err := While(func() bool {
-		return false
+		return true
 	}, func() (int, error) {
 		return 0, expectedErr
 	})
@@ -86,9 +86,9 @@ func TestWhileWithContext(t *testing.T) {
 	out, err := WhileWithContext(ctx, func(ctx context.Context) bool {
 		select {
 		case <-ctx.Done():
-			return true
-		default:
 			return false
+		default:
+			return true
 		}
 	}, func() {
 	})