cpu: skip NOPs to avoid barriers #17133
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I was testing matmul chunking I noticed that we're still doing barriers for the NOPs.
This PR adds explicit check for NOPs in the
graph_compute_threadso that we can skip the barriers.I instrumented the code to see how many we actually skip for various models and it's quite a bit.
The numbers below are per-graph (ie per-token, etc)
The overall speed up is noticeable for smaller models, but this makes sense in general to avoid waisting cycles.
Here is M4 Pro Qwen3-0.6B on the CPU before and after.
I'm seeing similar bump on the Snapdragons, not so much on the Prompt but definitely for Token Gen.